Community
Participate
Working Groups
WikiText's Creole support is currently limited by the absence of a DocumentBuilder for Creole. It would be useful to have a DocumentBuilder implementation capable of generating markup in the Creole markup language.
New Gerrit change created: https://git.eclipse.org/r/133621
Thank you for providing an implementation Kevin. This contribution is quite large thought, and it would help reviewers and committers if you could break this up into smaller logical contributions. We took a similar approach when I provided the Markdown document builder some time ago https://bugs.eclipse.org/bugs/show_bug.cgi?id=440935. You might want to break this down in a similar manner. And just to cover all bases, you should confirm that you authored this code and you're within your rights to break down and modify it.
(In reply to Leo Dos Santos from comment #3) > Thank you for providing an implementation Kevin. This contribution is quite > large thought, and it would help reviewers and committers if you could break > this up into smaller logical contributions. We took a similar approach when > I provided the Markdown document builder some time ago > https://bugs.eclipse.org/bugs/show_bug.cgi?id=440935. You might want to > break this down in a similar manner. > > And just to cover all bases, you should confirm that you authored this code > and you're within your rights to break down and modify it. Yep, I am the sole author of the code submitted above. Thanks for the advice, I'll modify the review and break it down into smaller commits.
Gerrit change https://git.eclipse.org/r/133621 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=e598a5dcba6ec4e9e21fa6112a00b7b2dc351c16
New Gerrit change created: https://git.eclipse.org/r/133701
Gerrit change https://git.eclipse.org/r/133701 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=317fdc306f8324a93dec3a2f6aeee4019bda254e
New Gerrit change created: https://git.eclipse.org/r/133795
Gerrit change https://git.eclipse.org/r/133795 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=722849a165c719c8adeb3ef6c23c46cfde3e0530
New Gerrit change created: https://git.eclipse.org/r/133809
Gerrit change https://git.eclipse.org/r/133809 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=0f8fe05c66be21b0a03e61040190802215378461
New Gerrit change created: https://git.eclipse.org/r/133815
Gerrit change https://git.eclipse.org/r/133815 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=626faa5d89e32e2229a190759279916961ade974
New Gerrit change created: https://git.eclipse.org/r/133878
Gerrit change https://git.eclipse.org/r/133878 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=372e02c209c8cf666f1cc93f96ab5a25be8c8979
Gerrit change https://git.eclipse.org/r/134022 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=b08f6820b35251ff6e2d784f77562dae27e1f409
Thanks Kevin! Do you think there's anything else?
(In reply to Leo Dos Santos from comment #17) > Thanks Kevin! Do you think there's anything else? I think that covers all of the use cases I could find for a Creole document builder. (Largely based on what's provided in the spec outlined here: http://www.wikicreole.org/wiki/)
Great, I'll close this then. Thank you for the contribution!
