Bug 541854 - [Wayland] Ctrl+1 popup issues
Summary: [Wayland] Ctrl+1 popup issues
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.11 M1   Edit
Assignee: Xi Yan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 542104
  Show dependency tree
 
Reported: 2018-12-03 10:15 EST by Xi Yan CLA
Modified: 2019-01-09 10:49 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xi Yan CLA 2018-12-03 10:15:41 EST 
1) Ctrl+1 popup does not respond to double click immediately, only works if you click it once and then double click

2) On Flatpak only, using Ctrl+1 to bring up the quick fix popup, and then closing it causes crash with 1GTK_1IS_1WINDOW+0x16, from callback introduced from https://git.eclipse.org/r/#/c/132136/
Comment 1 Eclipse Genie CLA 2018-12-03 13:13:20 EST 
New Gerrit change created: https://git.eclipse.org/r/133414
Comment 3 Xi Yan CLA 2018-12-06 14:24:27 EST 
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/133414 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=3615a6bf1b910747186515b2526504f91dbe4dae

In master now.
Comment 4 Andrey Loskutov CLA 2018-12-06 14:27:33 EST 
(In reply to Xi Yan from comment #3)
> (In reply to Eclipse Genie from comment #2)
> > Gerrit change https://git.eclipse.org/r/133414 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> > ?id=3615a6bf1b910747186515b2526504f91dbe4dae
> 
> In master now.

Xi, you can't merge, master is closed for RC2 bugs only!!
Comment 5 Eclipse Genie CLA 2018-12-06 14:28:10 EST 
New Gerrit change created: https://git.eclipse.org/r/133608
Comment 7 Xi Yan CLA 2018-12-06 14:29:14 EST 
(In reply to Andrey Loskutov from comment #4)
> (In reply to Xi Yan from comment #3)
> > (In reply to Eclipse Genie from comment #2)
> > > Gerrit change https://git.eclipse.org/r/133414 was merged to [master].
> > > Commit:
> > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> > > ?id=3615a6bf1b910747186515b2526504f91dbe4dae
> > 
> > In master now.
> 
> Xi, you can't merge, master is closed for RC2 bugs only!!

Sorry! It's reverted now.
Comment 8 Eclipse Genie CLA 2018-12-11 10:09:34 EST 
New Gerrit change created: https://git.eclipse.org/r/133861
Comment 10 Eric Williams CLA 2018-12-11 12:17:42 EST 
(In reply to Eclipse Genie from comment #9)
> Gerrit change https://git.eclipse.org/r/133861 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=0e7557472c35a7863593f5db14fabdcafdaab23e

Patch is in master once again, thanks Xi.
Comment 11 Eric Williams CLA 2019-01-09 10:49:24 EST 
Verified in I20190108-1800.