Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #541513 +++ Currently, when the DDRepresentationDescriptor.target is null, * the representation is grayed in the Model Explorer tree. * the only avaiblable action on representation is Delete The aim of this ticket is to extend this behavior to the representation that is not reachable: * either because the DRepresentationDescriptor repPath is null * or the DRepresentationDescriptor repPath contains an URI that is not reachable. It is the case for example if the DRepresentation is deleted. These cases happens when: - there is a bad fragment in the repPath URI - there is a bad segment in the repPath URI - the DRepresentation is not existing anymore In addition, the filter _Representations known as dangling_ would be renamed in _Representations known as invalid_. It would cover the dangling and the non reachable representation
Created attachment 276777 [details] Invalid representation projects
New Gerrit change created: https://git.eclipse.org/r/133294
New Gerrit change created: https://git.eclipse.org/r/133297
New Gerrit change created: https://git.eclipse.org/r/133296
New Gerrit change created: https://git.eclipse.org/r/133295
Created attachment 276779 [details] Invalid representation projects
STEPS TO VALIDATE * open both projects from "Invalid representation projects" attached file * In "Model Explorer" view, expand both semantic model and "representation per category" node to see the 6 representation -> In the testEcoreInvalidRep project, only "new ClassesDiagram Correct" representation should be valid(icon and text not grayed) -> In the testEcoreInvalidRepSplit project, only "new ClassesDiagram Correct" and "P0 package entities with bad repPath fragment" representations should be valid(icon and text not grayed) * right click on a valid representation under the semantic model tree -> Open, Delete, Rename, Copy, "Extract to aird file" and "Export representations as images" actions should be displayed in the contextual menu * right click on a valid representation under "representations per category" -> Open, Delete, Rename, Copy, "Extract to aird file", "Export representations as images" , Control (and eventually some other actions) actions should be displayed in the contextual menu * right click on an INVALID representation both under the semantic model tree or under "representations per category" -> Only Delete action should be displayed in the contextual menu * Click on "Customize view" button and then check "Representations known as invalid" -> Invalid representations should not be displayed any more in the Model Explorer
Gerrit change https://git.eclipse.org/r/133295 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5653fa9426138cea13a26359371e3684625431a2
Gerrit change https://git.eclipse.org/r/133296 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=afe9a7ee58cb90eb51c2067e3b2f41f6d824dd7c
Gerrit change https://git.eclipse.org/r/133297 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=389a96c36400ad62caf56bef05102661f37e993e
Gerrit change https://git.eclipse.org/r/133294 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b39909c9f39387e9e300fca93b8acf749a7fbe3c
New Gerrit change created: https://git.eclipse.org/r/134513
Gerrit change https://git.eclipse.org/r/134513 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=23c39a8f1a49de71f5611c742484634c50602321
In addtion to the Description of this bug, there are changes on contextual menu in Model Explorer. Contextual menus on invalid representations display only the Delete action. STEPS TO VALIDATE In addition to Comment 7 there is another scenario to test: * right click on P0 package that contains many invalid representations * click "Export representations as images" -> only valid representation should be exported as images
Verified with OD CE 11.1.2 On invalid representations we can have additional menu Sow references/ Show EClass information.
Available in Sirius 6.1.2, see https://wiki.eclipse.org/Sirius/6.1.2 for details.
