Community
Participate
Working Groups
Currently, when the DDRepresentationDescriptor.target is null, * the representation is grayed in the Model Explorer tree. * the only avaiblable action on representation is Delete The aim of this ticket is to extend this behavior to the representation that is not reachable: * either because the DRepresentationDescriptor repPath is null * or the DRepresentationDescriptor repPath contains an URI that is not reachable. It is the case for example if the DRepresentation is deleted. These cases happens when: - there is a bad fragment in the repPath URI - there is a bad segment in the repPath URI - the DRepresentation is not existing anymore In addition, the filter _Representations known as dangling_ would be renamed in _Representations known as invalid_. It would cover the dangling and the non reachable representation
Created attachment 276677 [details] Invalid representation projects
New Gerrit change created: https://git.eclipse.org/r/133143
New Gerrit change created: https://git.eclipse.org/r/133142
New Gerrit change created: https://git.eclipse.org/r/133141
STEPS TO VALIDATE * open both projects from "Invalid representation projects" attached file * In "Model Explorer" view, expand both semantic model and "representation per category" node to see the 6 representation -> In the testEcoreInvalidRep project, only "new ClassesDiagram Correct" representation should be valid(icon and text not grayed) -> In the testEcoreInvalidRepSplit project, only "new ClassesDiagram Correct" and "P0 package entities with bad repPath fragment" representations should be valid(icon and text not grayed) * right click on a valid representation -> Open, Delete, Rename, Copy, "Extract to aird file" and "Export representations as images" actions should be displayed in the contextual menu * right click on an INVALID representation -> Only Delete action should be displayed in the contextual menu * Click on "Customize view" button and then check "Representations known as invalid" -> Invalid representations should not be displayed any more in the Model Explorer
Created attachment 276765 [details] Invalid representation projects
VALIDATION Edition of Comment 5, for the step "right click on an INVALID representation" and "right click on an INVALID representation" * right click on a valid representation under the semantic model tree -> Open, Delete, Rename, Copy, "Extract to aird file" and "Export representations as images" actions should be displayed in the contextual menu * right click on a valid representation under "representations per category" -> Open, Delete, Rename, Copy, "Extract to aird file", "Export representations as images" , Control (and eventually some other actions) actions should be displayed in the contextual menu * right click on an INVALID representation both under the semantic model tree or under "representations per category" -> Only Delete action should be displayed in the contextual menu
New Gerrit change created: https://git.eclipse.org/r/133288
Gerrit change https://git.eclipse.org/r/133143 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=df59f5237a6f39ba8162c57c206fbb6dcd121470
Gerrit change https://git.eclipse.org/r/133288 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cb4fcb1e251fc40f083a62f641c5734a8538ed3a
Gerrit change https://git.eclipse.org/r/133141 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cf22e4cd86025eeddbc393c2c88938147691ab7e
Gerrit change https://git.eclipse.org/r/133142 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=26ccdfc33e68b55f3e9f0d6f052d1ec2a5166d65
New Gerrit change created: https://git.eclipse.org/r/133301
Gerrit change https://git.eclipse.org/r/133301 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7cda60505d171252b0aa2e70a86ae1082da5dc36
New Gerrit change created: https://git.eclipse.org/r/133317
Gerrit change https://git.eclipse.org/r/133317 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6c8f5117cbd13a3b43ecd7f0b5ef2ea43e17623a
By right clicking on an INVALID representation both under the semantic model tree or under "representations per category", there is 2 actions in the contextual menu "Extract to aird file" and "Export Representation as image" which should not appear.
There was a mistake in the scenario. Below is the expected * right click on an INVALID representation both under the semantic model tree or under "representations per category" -> Only Delete, "Extract to aird file" and "Export Representation as image" actions should be displayed in the contextual menu "Extract to aird file" and "Export Representation as image" have been kept because otherwise it would have implied some impacting changes in the code that were not in the scope of this ticket.
validated with DOREMI 11.0.1RC2
Available in Sirius 5.1.4, see https://wiki.eclipse.org/Sirius/5.1.4 for details.
