Community
Participate
Working Groups
org.eclipse.ui.test testCancelWizardCancelsJob failed on windows in the build I20181121-1800 The stack trace is given below: junit.framework.AssertionFailedError: Wizard should show progress monitor at junit.framework.Assert.fail(Assert.java:57) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.TestCase.assertTrue(TestCase.java:192) at org.eclipse.ui.tests.datatransfer.SmartImportTests.testCancelWizardCancelsJob(SmartImportTests.java:269)
I am not able to reproduce the test failure on local windows machine.
This test also failedon Mac test machine for the build I20190522-1800 https://download.eclipse.org/eclipse/downloads/drops4/I20190522-1800/testresults/html/org.eclipse.ui.tests_ep412I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html with the below stack trace Progress monitor should be hidden within 10 seconds junit.framework.AssertionFailedError: Progress monitor should be hidden within 10 seconds at junit.framework.Assert.fail(Assert.java:57) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertFalse(Assert.java:39) at junit.framework.TestCase.assertFalse(TestCase.java:210) at org.eclipse.ui.tests.datatransfer.SmartImportTests.testCancelWizardCancelsJob(SmartImportTests.java:291)
New Gerrit change created: https://git.eclipse.org/r/156679
I looked into this test but couldn't find a reason for failure yet. However I found a small bug in SmartImport which could be related (bug 559600) and have a rough idea what might be the failure reason for Windows. Maybe File.listRoots()[0] isn't what the test author expected. In general the order is not guaranteed. I added a log statement to see what is actual used on test machine.
Gerrit change https://git.eclipse.org/r/156679 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c5551f65eec99c3057712065840dbbbd5f7318a7
Quote from the latest test log: > !ENTRY org.eclipse.ui.tests 1 0 2020-01-28 05:04:36.074 > !MESSAGE Testing job cancel with root: A:\ I love it to be right. In fact I expected exactly this result in the first place but was far too uncertain to make a prediction. I mean drive letter A:\ is in any case I know reserved for floppy drives and when was the last time you saw such things. I'll push a patch.
New Gerrit change created: https://git.eclipse.org/r/156696
Gerrit change https://git.eclipse.org/r/156696 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c2854dbeafec3f3db54476dbc2758fef349bea45
Paul, can you also look at this on Mac where it also fails?
No. Have no access to any Mac. I have not even a good guess why it is failing on Mac. Things someone could do: - run test and look if the progress stuff/cancel button is indeed visible or falsely detected as visible - if visible click the cancel button while the test is running. If that works the test code to trigger cancel might be broken. - check manual in SDK if cancellation works on Mac
(In reply to Paul Pazderski from comment #10) > No. Have no access to any Mac. I have not even a good guess why it is > failing on Mac. > > Things someone could do: > - run test and look if the progress stuff/cancel button is indeed visible > or falsely detected as visible > - if visible click the cancel button while the test is running. If that > works the test code to trigger cancel might be broken. > - check manual in SDK if cancellation works on Mac I have tried the steps above on local Mac machine and the progress stuff/cancel button is indeed visible and the test code to trigger the cancellation as well as manual cancellation both work. This test does not fail on local mac machine.
What's the status here?
(In reply to Dani Megert from comment #12) > What's the status here? This test has not been failing in the IBuilds for some time atleast from I20200217-0600.
(In reply to Kalyan Prasad Tatavarthi from comment #13) > (In reply to Dani Megert from comment #12) > > What's the status here? > > This test has not been failing in the IBuilds for some time atleast from > I20200217-0600. Please reopen if it fails again.
(In reply to Dani Megert from comment #14) > (In reply to Kalyan Prasad Tatavarthi from comment #13) > > (In reply to Dani Megert from comment #12) > > > What's the status here? > > > > This test has not been failing in the IBuilds for some time atleast from > > I20200217-0600. > Please reopen if it fails again. This test Failed in the build I20200429-1800 on Mac https://download.eclipse.org/eclipse/downloads/drops4/I20200429-1800/testresults/html/org.eclipse.ui.tests_ep416I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html It also failed in the 4.16 M1 build on Mac https://download.eclipse.org/eclipse/downloads/drops4/S-4.16M1-202004090200/testresults/html/org.eclipse.ui.tests_ep416I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html So Reopening the bug.
This test Failed in the build I20210526-2310 on Mac https://download.eclipse.org/eclipse/downloads/drops4/I20210526-2310/testresults/html/org.eclipse.ui.tests_ep420I-unit-mac64-java11_macosx.cocoa.x86_64_11.html
