Bug 541353 - [tests] Sporadic fails in CharsetTest testDeltasContainer and testBug207510
Summary: [tests] Sporadic fails in CharsetTest testDeltasContainer and testBug207510
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 4.9   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.11 M3   Edit
Assignee: Simeon Andreev CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-20 05:51 EST by Simeon Andreev CLA
Modified: 2019-02-07 04:05 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simeon Andreev CLA 2018-11-20 05:51:47 EST
We see fails from time to time in gerrit reviews, examples are:


  Error Message

    5.2 Verifying delta for /
    Verifying delta for /project1
    Verifying delta for /project1/.settings
    Verifying delta for /project1/.settings/org.eclipse.core.resources.prefs
    Verifying delta for /
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /project1
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /project1/.settings
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /project1/.settings/org.eclipse.core.resources.derived.prefs

    Stacktrace

    junit.framework.AssertionFailedError:
    5.2 Verifying delta for /
    Verifying delta for /project1
    Verifying delta for /project1/.settings
    Verifying delta for /project1/.settings/org.eclipse.core.resources.prefs
    Verifying delta for /
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /project1
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /project1/.settings
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /project1/.settings/org.eclipse.core.resources.derived.prefs

    at org.eclipse.core.tests.resources.CharsetTest.testBug207510(CharsetTest.java:605)


    Error Message

    4.2.Verifying delta for /
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/.settings
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/.settings/org.eclipse.core.resources.prefs
    Verifying delta for /
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/folder1
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/folder1/file1.txt

    Stacktrace

    junit.framework.AssertionFailedError:
    4.2.Verifying delta for /
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/.settings
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/.settings/org.eclipse.core.resources.prefs
    Verifying delta for /
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4
    Missing expected change
    Actual kind: <CHANGED>
    Actual change flags: <0>
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/folder1
    Verifying delta for /b0010b5e3dd100181091d762cb8d30b4/folder1/file1.txt

    at org.eclipse.core.tests.resources.CharsetTest.testDeltasContainer(CharsetTest.java:1218)



    Build Unstablehttps://ci.eclipse.org/platform/job/eclipse.platform.resources-Gerrit/981/
    : UNSTABLE

    Test Result (2 failures / ±0)

    org.eclipse.core.tests.resources.CharsetTest.testBug207510

    Error Message

    4.2 /project1/.settings/org.eclipse.core.resources.derived.prefs unexpectedly exists in the workspace

    Stacktrace

    junit.framework.AssertionFailedError: 4.2 /project1/.settings/org.eclipse.core.resources.derived.prefs unexpectedly exists in the workspace
    at org.eclipse.core.tests.resources.CharsetTest.testBug207510(CharsetTest.java:590)


junit.framework.AssertionFailedError: 
5.1.Verifying delta for /
Verifying delta for /50211a443be700181c2ac08d9f97f7c8
Verifying delta for /50211a443be700181c2ac08d9f97f7c8/.settings
Verifying delta for /50211a443be700181c2ac08d9f97f7c8/.settings/org.eclipse.core.resources.prefs
Verifying delta for /
	Missing expected change
		Actual kind: <CHANGED>
		Actual change flags: <0>
Verifying delta for /50211a443be700181c2ac08d9f97f7c8
	Missing expected change
		Actual kind: <CHANGED>
		Actual change flags: <0>
Verifying delta for /50211a443be700181c2ac08d9f97f7c8/folder1
Verifying delta for /50211a443be700181c2ac08d9f97f7c8/folder1/file1.txt

	at org.eclipse.core.tests.resources.CharsetTest.testDeltasContainer(CharsetTest.java:1230)


Would be nice to fix those, to remove the noise.
Comment 1 Eclipse Genie CLA 2018-11-20 08:04:59 EST
New Gerrit change created: https://git.eclipse.org/r/132746
Comment 2 Simeon Andreev CLA 2018-11-20 08:13:37 EST
testBug207510 should be a simple case of not waiting enough for some jobs from CharsetManager to finish. In bug 341073 5 seconds of waiting were added, which is generally a bad idea when waiting for jobs.

testDeltasContainer seems more complicated; the deltas are received directly in the test thread (the main thread), or so it seems. The test code ignores deltas from other threads though, so maybe that is a problem. I'll try to add more infos to the fail, to print the actual deltas that were seen by the test. Stating what the test expected but did not see is not particularly helpful.
Comment 4 Eclipse Genie CLA 2018-11-22 09:39:24 EST
New Gerrit change created: https://git.eclipse.org/r/132901
Comment 6 Eclipse Genie CLA 2018-12-06 03:58:05 EST
New Gerrit change created: https://git.eclipse.org/r/133581
Comment 7 Simeon Andreev CLA 2019-01-28 05:52:16 EST
OK, if I wait at a breakpoint in CharsetManager.flushPreferences() (2 seconds at each hit before allowing execution to continue), I see failures both in CharsetTests.testDeltasContainer() and in CharsetTests.testBug207510() (despite the added patch).

It seems that flushing preferences during CharsetManagerJob will trigger another job: org.eclipse.core.internal.events.NotificationManager.NotifyJob.NotifyJob(NotificationManager)

See stack trace:

java.lang.Exception: requested notification, job delay is: 1500
	at org.eclipse.core.internal.events.NotificationManager.requestNotify(NotificationManager.java:210)
	at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1486)
	at org.eclipse.core.internal.resources.Resource.refreshLocal(Resource.java:1555)
	at org.eclipse.core.internal.resources.ProjectPreferences.lambda$0(ProjectPreferences.java:624)
	at org.eclipse.core.internal.resources.ProjectPreferences.save(ProjectPreferences.java:665)
	at org.eclipse.core.internal.preferences.EclipsePreferences.internalFlush(EclipsePreferences.java:432)
	at org.eclipse.core.internal.resources.ProjectPreferences.flush(ProjectPreferences.java:371)
	at org.eclipse.core.internal.resources.ProjectPreferences.flush(ProjectPreferences.java:374)
	at org.eclipse.core.internal.resources.CharsetManager.flushPreferences(CharsetManager.java:269)
	at org.eclipse.core.internal.resources.CharsetManager$CharsetManagerJob.run(CharsetManager.java:97)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)


This job will set a flag to forcefully notify on the next workspace operation end. The NotifyJob is scheduled with some delay (usually 1.5 seconds). Once this delay runs out, the notification flag (NotificationManager.notificationRequested) is set and the next CharsetManagerJob that flushes preferences will result in another, unexpected, delta.

So far I'm not sure how to resolve this, as waiting for NotifyJob after waiting for CharsetManagerJob doesn't fix the problem. I believe this is due to the test changing a file, the CharsetManagerJob triggering a few times, and each of those triggers scheduling the NotifyJob with some delay. If the test is taking long for whatever reason, the notification flag is set and unexpected (by the test) deltas are observed.
Comment 8 Simeon Andreev CLA 2019-01-28 07:23:25 EST
I checked the fail on breakpoint wait, and a pass. The difference is that when the test passes, there is *one* delta containing changes:

ResourceDelta(/)
delta child: ResourceDelta(/)
delta child: ResourceDelta(/project1)
delta child: ResourceDelta(/project1/.settings)
delta child: ResourceDelta(/project1/.settings/org.eclipse.core.resources.derived.prefs)
delta child: ResourceDelta(/project1/.settings/org.eclipse.core.resources.prefs)

In the fail case, there are two deltas:

ResourceDelta(/)
delta child: ResourceDelta(/)
delta child: ResourceDelta(/project1)
delta child: ResourceDelta(/project1/.settings)
delta child: ResourceDelta(/project1/.settings/org.eclipse.core.resources.prefs)

ResourceDelta(/)
delta child: ResourceDelta(/)
delta child: ResourceDelta(/project1)
delta child: ResourceDelta(/project1/.settings)
delta child: ResourceDelta(/project1/.settings/org.eclipse.core.resources.derived.prefs)

The fail case is due to NotificationJob actually running, before its cancelled (see comment 7). Normally this job is cancelled right away on any workspace job, so I'm not 100% sure 

I'll add the entire received deltas to the extra fail message. I'll also see if the test verifier can deal with this case as well.
Comment 10 Simeon Andreev CLA 2019-01-28 09:56:33 EST
org.eclipse.core.tests.resources.ResourceDeltaVerifier.addExpectedChange(IResource, IResource, int, int, IPath, IPath) runs extra code to put the entire parent path as expected changes for any expected change added by the test. This parent path is then missing for the 2nd delta (as its consumed during the first delta, the expected changes are stored in a hash map from resource path to expected change).

An obvious crutch is adding two other listeners that listen for the individual resource deltas. If either the original listener or those two listeners are satisfied, then the test passes. This would not touch the existing verification code, which is used in I believe 14 test cases and whatever their extending test cases are (see references of org.eclipse.core.tests.resources.ResourceDeltaVerifier).
Comment 11 Simeon Andreev CLA 2019-01-29 05:37:47 EST
Here is a failure in testDeltaContainer, when waiting a bit on CharsetManager.flushPreferences() breakpoints. This failure is more obscure since all of the delta notifications are done in the main thread:

junit.framework.AssertionFailedError: 5.1.Delta verification triggered:
java.lang.Thread.getStackTrace(Thread.java:1559),
org.eclipse.core.tests.resources.CharsetTest$CharsetVerifierWithExtraInfo.verifyDelta(CharsetTest.java:1611),
org.eclipse.core.tests.resources.ResourceDeltaVerifier.resourceChanged(ResourceDeltaVerifier.java:798),
org.eclipse.core.tests.resources.CharsetTest$CharsetVerifier.resourceChanged(CharsetTest.java:94),
org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:300),
org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45),
org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:290),
org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:153),
org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:379),
org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1502),
org.eclipse.core.internal.resources.File.setContents(File.java:347),
org.eclipse.core.internal.resources.ProjectPreferences.lambda$0(ProjectPreferences.java:637),
org.eclipse.core.internal.resources.ProjectPreferences.save(ProjectPreferences.java:664),
org.eclipse.core.internal.preferences.EclipsePreferences.internalFlush(EclipsePreferences.java:432),
org.eclipse.core.internal.resources.ProjectPreferences.flush(ProjectPreferences.java:371),
org.eclipse.core.internal.resources.ProjectPreferences.flush(ProjectPreferences.java:374),
org.eclipse.core.internal.resources.CharsetManager.flushPreferences(CharsetManager.java:264),
org.eclipse.core.internal.resources.CharsetManager.setCharsetFor(CharsetManager.java:447),
org.eclipse.core.internal.resources.Container.setDefaultCharset(Container.java:343),
org.eclipse.core.tests.resources.CharsetTest.testDeltasContainer(CharsetTest.java:1238),
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method),
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62),
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43),
java.lang.reflect.Method.invoke(Method.java:498),
junit.framework.TestCase.runTest(TestCase.java:176),
junit.framework.TestCase.runBare(TestCase.java:141),
junit.framework.TestResult$1.protect(TestResult.java:122),
junit.framework.TestResult.runProtected(TestResult.java:142),
junit.framework.TestResult.run(TestResult.java:125),
junit.framework.TestCase.run(TestCase.java:129),
junit.framework.TestSuite.runTest(TestSuite.java:252),
junit.framework.TestSuite.run(TestSuite.java:247),
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86),
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89),
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41),
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:541),
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:763),
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:463),
org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:232),
org.eclipse.pde.internal.junit.runtime.PlatformUITestHarness.lambda$0(PlatformUITestHarness.java:45),
org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40),
org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185),
org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5012),
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4570),
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1173),
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339),
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1062),
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155),
org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:636),
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339),
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563),
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151),
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:155),
org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.runApp(NonUIThreadTestApplication.java:55),
org.eclipse.pde.internal.junit.runtime.UITestApplication.runApp(UITestApplication.java:46),
org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.start(NonUIThreadTestApplication.java:49),
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203),
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137),
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107),
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400),
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255),
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method),
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62),
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43),
java.lang.reflect.Method.invoke(Method.java:498),
org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659),
org.eclipse.equinox.launcher.Main.basicRun(Main.java:595),
org.eclipse.equinox.launcher.Main.run(Main.java:1501),
org.eclipse.equinox.launcher.Main.main(Main.java:1474)
delta child: ResourceDelta(/),
with flags: 0
delta child: ResourceDelta(/9094ee4fb123001916079852d6c06c27),
with flags: 0
delta child: ResourceDelta(/9094ee4fb123001916079852d6c06c27/.settings),
with flags: 0
delta child: ResourceDelta(/9094ee4fb123001916079852d6c06c27/.settings/org.eclipse.core.resources.prefs),
with flags: CONTENT
Verifying delta for /
Verifying delta for /9094ee4fb123001916079852d6c06c27
Verifying delta for /9094ee4fb123001916079852d6c06c27/.settings
Verifying delta for /9094ee4fb123001916079852d6c06c27/.settings/org.eclipse.core.resources.prefs
Delta verification triggered:
java.lang.Thread.getStackTrace(Thread.java:1559),
org.eclipse.core.tests.resources.CharsetTest$CharsetVerifierWithExtraInfo.verifyDelta(CharsetTest.java:1611),
org.eclipse.core.tests.resources.ResourceDeltaVerifier.resourceChanged(ResourceDeltaVerifier.java:798),
org.eclipse.core.tests.resources.CharsetTest$CharsetVerifier.resourceChanged(CharsetTest.java:94),
org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:300),
org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45),
org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:290),
org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:153),
org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:379),
org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1502),
org.eclipse.core.internal.resources.Container.setDefaultCharset(Container.java:384),
org.eclipse.core.tests.resources.CharsetTest.testDeltasContainer(CharsetTest.java:1238),
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method),
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62),
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43),
java.lang.reflect.Method.invoke(Method.java:498),
junit.framework.TestCase.runTest(TestCase.java:176),
junit.framework.TestCase.runBare(TestCase.java:141),
junit.framework.TestResult$1.protect(TestResult.java:122),
junit.framework.TestResult.runProtected(TestResult.java:142),
junit.framework.TestResult.run(TestResult.java:125),
junit.framework.TestCase.run(TestCase.java:129),
junit.framework.TestSuite.runTest(TestSuite.java:252),
junit.framework.TestSuite.run(TestSuite.java:247),
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86),
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89),
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41),
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:541),
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:763),
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:463),
org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:232),
org.eclipse.pde.internal.junit.runtime.PlatformUITestHarness.lambda$0(PlatformUITestHarness.java:45),
org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40),
org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185),
org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5012),
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4570),
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1173),
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339),
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1062),
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155),
org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:636),
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339),
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563),
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151),
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:155),
org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.runApp(NonUIThreadTestApplication.java:55),
org.eclipse.pde.internal.junit.runtime.UITestApplication.runApp(UITestApplication.java:46),
org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.start(NonUIThreadTestApplication.java:49),
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203),
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137),
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107),
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400),
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255),
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method),
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62),
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43),
java.lang.reflect.Method.invoke(Method.java:498),
org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659),
org.eclipse.equinox.launcher.Main.basicRun(Main.java:595),
org.eclipse.equinox.launcher.Main.run(Main.java:1501),
org.eclipse.equinox.launcher.Main.main(Main.java:1474)
delta child: ResourceDelta(/),
with flags: 0
delta child: ResourceDelta(/9094ee4fb123001916079852d6c06c27),
with flags: 0
delta child: ResourceDelta(/9094ee4fb123001916079852d6c06c27/folder1),
with flags: ENCODING
delta child: ResourceDelta(/9094ee4fb123001916079852d6c06c27/folder1/file1.txt),
with flags: ENCODING
Verifying delta for /
	Missing expected change
		Actual kind: <CHANGED>
		Actual change flags: <0>
Verifying delta for /9094ee4fb123001916079852d6c06c27
	Missing expected change
		Actual kind: <CHANGED>
		Actual change flags: <0>
Verifying delta for /9094ee4fb123001916079852d6c06c27/folder1
Verifying delta for /9094ee4fb123001916079852d6c06c27/folder1/file1.txt
 at junit.framework.Assert.fail(Assert.java:57)
 at junit.framework.Assert.assertTrue(Assert.java:22)
 at junit.framework.TestCase.assertTrue(TestCase.java:192)
 at org.eclipse.core.tests.resources.CharsetTest.testDeltasContainer(CharsetTest.java:1242)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at junit.framework.TestCase.runTest(TestCase.java:176)
 at junit.framework.TestCase.runBare(TestCase.java:141)
 at junit.framework.TestResult$1.protect(TestResult.java:122)
 at junit.framework.TestResult.runProtected(TestResult.java:142)
 at junit.framework.TestResult.run(TestResult.java:125)
 at junit.framework.TestCase.run(TestCase.java:129)
 at junit.framework.TestSuite.runTest(TestSuite.java:252)
 at junit.framework.TestSuite.run(TestSuite.java:247)
 at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
 at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
 at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:541)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:763)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:463)
 at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:232)
 at org.eclipse.pde.internal.junit.runtime.PlatformUITestHarness.lambda$0(PlatformUITestHarness.java:45)
 at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
 at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
 at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5012)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4570)
 at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1173)
 at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
 at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1062)
 at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
 at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:636)
 at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
 at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563)
 at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151)
 at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:155)
 at org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.runApp(NonUIThreadTestApplication.java:55)
 at org.eclipse.pde.internal.junit.runtime.UITestApplication.runApp(UITestApplication.java:46)
 at org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.start(NonUIThreadTestApplication.java:49)
 at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
 at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
 at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400)
 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:498)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:595)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1501)
 at org.eclipse.equinox.launcher.Main.main(Main.java:1474)
Comment 12 Eclipse Genie CLA 2019-01-29 05:51:29 EST
New Gerrit change created: https://git.eclipse.org/r/135926
Comment 14 Andrey Loskutov CLA 2019-02-07 04:05:17 EST
Let assume this is fixed now.