Bug 541185 - [Wayland] Help popup close after a click
Summary: [Wayland] Help popup close after a click
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Xi Yan CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 542104
  Show dependency tree
 
Reported: 2018-11-15 02:56 EST by Aurélien Mora CLA
Modified: 2019-04-04 10:18 EDT (History)
3 users (show)

See Also:
akurtakov: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aurélien Mora CLA 2018-11-15 02:56:51 EST 
Hello,

I encounter a weird behaviour with the help popups (when I let my cursor on a class/method name in java editor). These popup appears correctly, but when I click on then, it will close itself. This prevent me to follow the javadoc links inside the popup, or to select/copy text of javadoc.

This bug appears with debug popup too (when I try to inspect the value of a variable by letting my cursor on it).

System:
Archlinux
Gtk3 3.24.1+8+g220f77d8c1-1
Comment 1 Eric Williams CLA 2018-11-15 08:46:20 EST 
I can reproduce this, I think it's a regression from bug 533710. Xi, please investigate.
Comment 2 Eclipse Genie CLA 2018-11-15 14:49:26 EST 
New Gerrit change created: https://git.eclipse.org/r/132509
Comment 4 Eclipse Genie CLA 2018-11-26 10:27:47 EST 
New Gerrit change created: https://git.eclipse.org/r/133074
Comment 6 Xi Yan CLA 2018-11-26 15:18:32 EST 
(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/132509 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=4f1dc4d293b947f57c46577c047c26655532a383

This patch should fix the issue with Javadoc popup and debug popup closing when clicking into it.

But this is not a complete fix since there is still an issue with the auto-completion popup closing when highlighting text: 

1) open the auto-completion popup and switch focus to the completion details page using *tab* (not with mouse)

2) clicking the links inside the completion details page does not close the popup, but highlighting the text closes the popup. 

So leaving this ticket open for now.
Comment 7 Xi Yan CLA 2018-12-06 14:26:31 EST 
(In reply to Xi Yan from comment #6)
> (In reply to Eclipse Genie from comment #3)
> > Gerrit change https://git.eclipse.org/r/132509 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> > ?id=4f1dc4d293b947f57c46577c047c26655532a383
> 
> This patch should fix the issue with Javadoc popup and debug popup closing
> when clicking into it.
> 
> But this is not a complete fix since there is still an issue with the
> auto-completion popup closing when highlighting text: 
> 
> 1) open the auto-completion popup and switch focus to the completion details
> page using *tab* (not with mouse)
> 
> 2) clicking the links inside the completion details page does not close the
> popup, but highlighting the text closes the popup. 
> 
> So leaving this ticket open for now.

This is fixed in patch (https://git.eclipse.org/r/#/c/133414/)
Comment 8 Xi Yan CLA 2019-04-04 10:18:25 EDT 
Verified in I20190403-1800.