Community
Participate
Working Groups
Created attachment 276472 [details] Screenshot I20181025-1800 Quick switch editor (Ctrl+E) popup can become too wide now which looks odd. See the attached screenshot. Looks like the width is now equal to the width of the longest entry in the list. It should be set to a standard width and the remaining part of the entry can be shown on hover along with a horizontal scroll bar at the bottom, similar to the Open Resource dialog.
Patrik, can you please take it over? I guess it is coming from bug 539446.
(In reply to Andrey Loskutov from comment #1) > Patrik, can you please take it over? I guess it is coming from bug 539446. Ping!
Currently, we are displaying the following string: WorkbenchPartReference.getTitle() + " - " = WorkbenchPartReference#getTitleToolTip() As seen in the screenshot, such string can be quite long. A possible solution is to put a scrollbar like on OpenResourceDialog or on the Ctrl + 3 dialog. To implement such a solution I will need to know how to compute a maximum size. - Is there any Dialog I can take as an example to compute the maximum size? (example: maximum size = 1/2 total width of the eclipse ide window)
(In reply to Patrik Suzzi from comment #3) > Currently, we are displaying the following string: > WorkbenchPartReference.getTitle() + " - " = > WorkbenchPartReference#getTitleToolTip() > > As seen in the screenshot, such string can be quite long. > > A possible solution is to put a scrollbar like on OpenResourceDialog or on > the Ctrl + 3 dialog. Nope. That would be horrible. > To implement such a solution I will need to know how to compute a maximum > size. > - Is there any Dialog I can take as an example to compute the maximum size? > > (example: maximum size = 1/2 total width of the eclipse ide window) I would either use 1/2 of the editor area or define a maximum number of characters and compute the length (must use the correct font). > the remaining part of the entry can be shown on hover Hover is already there. NOTE 1: The issue is not new. The popup could get wide before when the file has a really long name. NOTE 2: The current placement is wrong. It uses the window width instead of the editor area width. That can result in the popup to appear besides the editor.
Ping! One day left for 4.10.
(In reply to Dani Megert from comment #4) > (In reply to Patrik Suzzi from comment #3) > > Currently, we are displaying the following string: > > WorkbenchPartReference.getTitle() + " - " = > > WorkbenchPartReference#getTitleToolTip() > > > > As seen in the screenshot, such string can be quite long. > > > > A possible solution is to put a scrollbar like on OpenResourceDialog or on > > the Ctrl + 3 dialog. > > Nope. That would be horrible. I don't understand which one of the following you prefer: 1. remove the path and bring it to the previous state 2. add a scrollbar that shows only in case of overflow > > To implement such a solution I will need to know how to compute a maximum > > size. >... > > I would either use 1/2 of the editor area or define a maximum number of > characters and compute the length (must use the correct font). If you suggest using 1/2 of the editor area, I assume you suggest adding a scrollbar in case of overflow, and limit the width of the dialog to 1/2 editor area. > > the remaining part of the entry can be shown on hover > Hover is already there. > > > NOTE 1: The issue is not new. The popup could get wide before when the file > has a really long name. > > NOTE 2: The current placement is wrong. It uses the window width instead of > the editor area width. That can result in the popup to appear besides the > editor. - I can recompute the width of the dialog depending on the entries that are currently visible. - I am going to change the placement according to the width of the editor
Created attachment 276835 [details] This is the dialog that I would take as a model
When showing the path the scroll bar will most likely appear every time. Please revert the change and show the path in a hover.
Ping! M1 is next week.
Ping! M3 is next week
Mass change, please reset target if you still planning to fix this for 4.11.
(In reply to Dani Megert from comment #8) > When showing the path the scroll bar will most likely appear every time. > > Please revert the change and show the path in a hover. I am reverting the change and show the path in a hover. Please, note this revert defeats the purpose of bug 539446
New Gerrit change created: https://git.eclipse.org/r/142391
Gerrit change https://git.eclipse.org/r/142391 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=81f7177bb02c641f65fe583fbc15493b9031207c
Created attachment 278646 [details] Quick switch editor reverted to display short text, and full path on hover. As a consequence, I will re-open bug 539446
