Bug 540675 - [GTK4] Adapt to sizing machinery changes
Summary: [GTK4] Adapt to sizing machinery changes
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.11 M3   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 540385
  Show dependency tree
 
Reported: 2018-10-31 18:04 EDT by Eric Williams CLA
Modified: 2019-02-27 08:10 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2018-10-31 18:04:15 EDT 
gtk_widget_get_preferred_size() and its siblings are no longer part of GTK4. Use gtk_widget_measure() instead.
Comment 1 Eric Williams CLA 2019-01-07 17:01:36 EST 
Additionally, using FillLayout() does not show anything in GTK4, whereas RowLayout does.
Comment 2 Eric Williams CLA 2019-01-08 14:46:13 EST 
Another example:

1) Launch Bug542865_ShellChildrenCrash.
2) Launch GtkInspector.
3) Observe that the GtkScrolledWindow child of Shell (GtkWindow) has a 0px height.
Comment 3 Eclipse Genie CLA 2019-01-10 15:03:02 EST 
New Gerrit change created: https://git.eclipse.org/r/134907
Comment 5 Eclipse Genie CLA 2019-01-25 10:30:57 EST 
New Gerrit change created: https://git.eclipse.org/r/135773
Comment 7 Xi Yan CLA 2019-01-25 11:12:18 EST 
(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/135773 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=d120090e99d9a3249fdca7227321d867b1995b65

In master now.
Comment 8 Eclipse Genie CLA 2019-01-25 12:58:56 EST 
New Gerrit change created: https://git.eclipse.org/r/135785
Comment 10 Eric Williams CLA 2019-02-27 08:10:56 EST 
Verified in I20190219-0600.