Bug 540531 - [Dark Theme] "LSP Text Occurrences" background color not adapted
Summary: [Dark Theme] "LSP Text Occurrences" background color not adapted
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LSP4E (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Holger Voormann CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2018-10-27 06:47 EDT by Holger Voormann CLA
Modified: 2022-02-04 09:12 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Voormann CLA 2018-10-27 06:47:31 EDT
When switching to the dark theme, the background colors of the text editor annotations "LSP Text/Read/Write Occurrences" are not adapted.

In the Rust IDE, this leads to the same font color as the background color for text occurrences when switching to the dark theme by default (see https://stackoverflow.com/a/52929317).
Comment 1 Eclipse Genie CLA 2018-10-27 06:50:59 EDT
New Gerrit change created: https://git.eclipse.org/r/131541
Comment 2 Holger Voormann CLA 2018-10-27 07:03:37 EDT
This is caused in "org.eclipse.lsp4e" by the missing file "resources/css/dark.css" (the folder "resources" has not been added to the "bin.includes" build property).

As a workaround, the file "dark.css" (from http://git.eclipse.org/c/lsp4e/lsp4e.git/plain/org.eclipse.lsp4e/resources/css/dark.css) can be manually added into the "org.eclipse.lsp4e" plug-in JAR archive as "resources/css/dark.css".
Comment 4 Mickael Istria CLA 2018-10-28 06:56:51 EDT
Thanks Howlger.
I think this patch is a workaround, a good one, and that the best fix would be to dynamically compute or retrieve the color according to the background. Need for custom CSS in plugins is not so good to maintain. This issue and the StackOverflow discussion are yet another example of the bad pattern it is. But the workaround is well enough to mark this current ticket as resolved.
By the way, thank you very much for monitoring StackOverflow!
Comment 5 Mickael Istria CLA 2021-11-16 15:55:53 EST
Eclipse LSP4E is moving away from this bugs.eclipse.org issue tracker to https://github.com/eclipse/lsp4e/issues/ instead. If this issue is relevant to you, your action is required.
0. Verify this issue is still happening with latest LSP4E snapshots (from https://download.eclipse.org/lsp4e/snapshots )
  if issue has disappeared, please change status of this issue to "CLOSED WORKFORME" with some details about your testing environment and how you did verify the issue; and you're done
  if issue is still present with snapshots:
* Create a new issue at https://github.com/eclipse/lsp4e/issues/
  ** Use as title in GitHub the title of this Bugzilla ticket (may include the bug number or not, at your own convenience)
  ** In the GitHub description, start with a link to this bugzilla ticket
  ** Optionally add new content to the description if it can helps towards resolution
  ** Submit GitHub issue
* Update bugzilla ticket
  ** Add to "See also" property (up right column) the link to the newly created GitHub issue
  ** Add a comment "Migrated to <link-to-newly-created-GitHub-issue>"
  ** Set status as CLOSED MOVED
  ** Submit

All issues that remain open will be automatically closed soon. Then the Bugzilla component for LSP4E will be archived and made read-only.