Bug 54019 - [EditorMgmt] Request for close on editor drop down
Summary: [EditorMgmt] Request for close on editor drop down
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Hanna Farah CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 53089 53558 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-03-08 09:12 EST by Michael Van Meekeren CLA
Modified: 2004-05-19 16:00 EDT (History)
5 users (show)

See Also:


Attachments
Fixes bugs 54019 and 60476 (4.44 KB, patch)
2004-05-04 15:27 EDT, Hanna Farah CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA 2004-03-08 09:12:51 EST
pasted email from Erich Gamma --- 

Here are some wishes after having used the editor drop down for a while.

I understand the intent to keep it as simple as possible. 
One functionality I miss in the drop down is support to easily close an
editor without having to activate it first. Without this support I have to:
1) open the drop down
2) select the editor
3) select the close box

It woud be convenient to close an editor in the drop down directly.
For example:
*	support a context menu (as is done in the Favorites menu of IE)
*	support the ctrl+w short cut on the selection in the editor drop down
* 	provide some modifier click


Much less important but it would be neat to be able to activate an
editor without dismissing the drop down. For example a shift-click
activates the editor. This allows me to pre-view which editor it is.

--erich
Comment 1 Chris McLaren CLA 2004-03-21 17:30:49 EST
*** Bug 53558 has been marked as a duplicate of this bug. ***
Comment 2 Chris McLaren CLA 2004-03-21 17:35:08 EST
- i added the ability to press the DEL key to close editors in this drop down.
it leaves the drop down open.

- bug 53186 requests a context menu for the items in the dropdown list.

i'm keeping this bug open because:

- the functionality should probably be advertised to the user (perhaps i should
add 'press DEL to close' at the bottom of the dropdown)

- we should support proper keybindings for close: ctrl+w, or even customized
keybindings, advertising them to the user appropriately.

- 'shift-click' functionality (and the corresponding keyboard equivalent
'Shift+ENTER') 
Comment 3 Chris McLaren CLA 2004-03-21 17:39:01 EST
*** Bug 53089 has been marked as a duplicate of this bug. ***
Comment 4 Michael Van Meekeren CLA 2004-04-14 15:52:16 EDT
the Delete key does work, however we should have a close menu as well on the 
list.
Comment 5 Erich Gamma CLA 2004-05-02 18:22:53 EDT
It should also be possible to repeatedly press the delete key. Currently, 
after the first press of the delete key there is no more selection and you 
have to re-select. Pressing delete should automatically select the next item 
in the list.
Comment 6 Hanna Farah CLA 2004-05-04 15:27:19 EDT
Created attachment 10267 [details]
Fixes bugs 54019 and 60476

No default element is selected in the list.
Pressing DEL will remove the item and select the next available item.
A right-click pops up a close menu which does the same thing as pressing DEL.
In the text filter area: pressing down will move the user to the first element
in the list ; pressing up will move the user to the last element in the list.
Comment 7 Erich Gamma CLA 2004-05-04 18:17:11 EDT
(minor) since you have improved the cursor navigation behaviour... here is 
another possible improvement: when pressing down at the bottom of the list you 
could wrap-around to the first item in the list. I understand that home/end 
are already supported, but this is the behaviour supported in code assist and 
I got used to it. 
Comment 8 Kim Horne CLA 2004-05-05 09:00:37 EDT
Could you please open a new enhancement bug for that feature?
Comment 9 Erich Gamma CLA 2004-05-05 09:16:25 EDT
yes this is the right thing to do - sorry.

bug# 61038 it is
Comment 10 Kim Horne CLA 2004-05-05 09:27:17 EDT
Fix in HEAD.
Comment 11 Hanna Farah CLA 2004-05-19 16:00:03 EDT
Verified for integration build I20040519, Wed, 19 May 2004 -- 00:10 (-0400)
A new bug was created for additional comments not handled in this fix: Bug 63094