Bug 539392 - [GTK3] Replace deprecated GdkScreen monitor functions with GdkDisplay ones
Summary: [GTK3] Replace deprecated GdkScreen monitor functions with GdkDisplay ones
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.9   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.10 M1   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard: RHT
Keywords: triaged
: 539561 (view as bug list)
Depends on:
Blocks: 502193
  Show dependency tree
 
Reported: 2018-09-24 11:41 EDT by Eric Williams CLA
Modified: 2018-09-28 14:33 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2018-09-24 11:41:57 EDT 
This function is currently dynamic, but still runs on GTK3.22. It should be guarded and used only on GTK3.20-.
Comment 1 Eric Williams CLA 2018-09-24 14:26:05 EDT 
Upon further inspection, it seems there are a number of GdkScreen functions relating to monitors being called on GTK3.22. These should be replaced with GdkDisplay ones.
Comment 2 Eclipse Genie CLA 2018-09-24 16:10:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/129884
Comment 4 Eric Williams CLA 2018-09-26 14:48:16 EDT 
(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/129884 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=f24e126e2e1137715e4205f66b0e4d50d9e4445b

In master now.
Comment 5 Eric Williams CLA 2018-09-26 17:02:09 EDT 
One of the calls to gdk_monitor_get_geometry() is using the int from a for loop, not the handle. Pushing a quick fix now...
Comment 6 Eclipse Genie CLA 2018-09-26 17:03:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/130049
Comment 8 Eric Williams CLA 2018-09-26 17:11:22 EDT 
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/130049 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=9dd3fa3f27b2471ad1ec1c8c40b3c25f1aba0a80

In master now.
Comment 9 Eclipse Genie CLA 2018-09-27 00:16:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/130054
Comment 11 Lakshmi P Shanmugam CLA 2018-09-27 00:31:21 EDT 
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/130049 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9dd3fa3f27b2471ad1ec1c8c40b3c25f1aba0a80
> 
@Eric, the change didn't compile on gtk ppc64le. This is the console output -> https://hudson.eclipse.org/releng/view/SWT%20Natives/job/gtk_linux_ppc64le/57/console .
I've reverted the change so that the build can continue.
Comment 12 Alexander Kurtakov CLA 2018-09-27 01:43:03 EDT 
Eric the cast you introduced the GdkMonitor fails to compile on pre 3.22 Gtk as it was introduced in this version.
Comment 13 Lars Vogel CLA 2018-09-27 07:59:16 EDT 
Latest build does not start anymore on Ubuntu 18.04, see Bug 539561
Comment 14 Eric Williams CLA 2018-09-27 08:15:29 EDT 
(In reply to Alexander Kurtakov from comment #12)
> Eric the cast you introduced the GdkMonitor fails to compile on pre 3.22 Gtk
> as it was introduced in this version.

Ah yeah, my mistake. I'll push a revised patch today.

(In reply to Lars Vogel from comment #13)
> Latest build does not start anymore on Ubuntu 18.04, see Bug 539561

I'll investigate.
Comment 15 Eric Williams CLA 2018-09-27 08:17:52 EDT 
*** Bug 539561 has been marked as a duplicate of this bug. ***
Comment 16 Eclipse Genie CLA 2018-09-27 08:24:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/130069
Comment 18 Eric Williams CLA 2018-09-27 09:13:37 EDT 
(In reply to Eclipse Genie from comment #17)
> Gerrit change https://git.eclipse.org/r/130069 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=86e1d48f8e87f99f56ea69e6675778f1807b7789

Fixed crash, but didn't introduce casting issue which caused the build failure.
Comment 19 Eric Williams CLA 2018-09-28 14:33:18 EDT 
Verified in I20180927-1800.