539165 – API to configure ContentAssistant to ignore completion trigger chars

Bug 539165 - API to configure ContentAssistant to ignore completion trigger chars

Summary: API to configure ContentAssistant to ignore completion trigger chars

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Text (show other bugs)
Version:	4.8
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.10 M1
Assignee:	Mickael Istria
QA Contact:

URL:
Whiteboard:
Keywords:	api, noteworthy

Depends on:
Blocks:	348857
	Show dependency tree

Reported:	2018-09-17 16:53 EDT by Mickael Istria
Modified:	2018-10-10 08:04 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit 539199

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mickael Istria

2018-09-17 16:53:25 EDT

As the issue of auto-activate content-assist vs trigger chars (bug 348857) is pretty general and could apply to any editor, and since some extensions may assume that content-assist is always triggered manually and then can rely a lot on trigger chars, we need a generic way to disable those for any editor.

I suggest addition of a ContentAssistant.enableCompletionTriggerChars(boolean) method. By default, trigger char are enabled.

Comment 1 Mickael Istria

2018-09-17 16:58:00 EDT

This involves adding a flag + getter + setter in ContentAssistant, and using this flag in CompletionProposalPopup.verifyKey(...)

Comment 2 Eclipse Genie

2018-09-17 17:55:52 EDT

New Gerrit change created: https://git.eclipse.org/r/129576

Comment 3 Eclipse Genie

2018-09-18 04:07:56 EDT

Gerrit change https://git.eclipse.org/r/129576 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=3c80a177e44f9924952496eeb79d87b7ea955a9d

Comment 4 Eclipse Genie

2018-09-18 04:58:04 EDT

New Gerrit change created: https://git.eclipse.org/r/129603

Comment 5 Eclipse Genie

2018-09-18 05:00:17 EDT

Gerrit change https://git.eclipse.org/r/129603 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=aef959c4a84dd0f54e28e93cc5ed03855e0111df

Comment 6 Lars Vogel

2018-09-18 05:10:49 EDT

Please add to N&N before marking as fixed.

Comment 7 Lakshmi P Shanmugam

2018-10-10 08:04:01 EDT

(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/129603 was merged to [master].
> Commit:
> http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=aef959c4a84dd0f54e28e93cc5ed03855e0111df
> 

Added bug number comment to the entry - http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=d1c56e924527a90d509951abf552ab103a459113