Community
Participate
Working Groups
Created attachment 275673 [details] Adapted DateTime snippet (Snippet 250) When editing a date or a time in a DateTime configured with the SWT.DATE or SWT.TIME style bits, the editing does not work: Simply an integer is shown instead of the day, month and year for a date or the hours, minutes and seconds for a time. This makes the widget comletely unusable with the aforementioned style bits.
Created attachment 275674 [details] Broken editing of Date and Time
I can reproduce the issue. Also, clicking the entry seems to cause a NPE.
This is caused by: https://git.eclipse.org/r/#/c/126598/
(In reply to Xi Yan from comment #3) > This is caused by: https://git.eclipse.org/r/#/c/126598/ I'm sorry I have no Linux access this week. Simeon, can you please check this?
(In reply to Andrey Loskutov from comment #4) > (In reply to Xi Yan from comment #3) > > This is caused by: https://git.eclipse.org/r/#/c/126598/ > > I'm sorry I have no Linux access this week. Simeon, can you please check > this? I think I have a fix right now, will upload to Gerrit after some testing.
New Gerrit change created: https://git.eclipse.org/r/128655
Gerrit change https://git.eclipse.org/r/128655 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4637faea28199f85d42a4ca237ad145cd1f2d386
New Gerrit change created: https://git.eclipse.org/r/128665
Gerrit change https://git.eclipse.org/r/128665 was merged to [R4_9_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7c48661aa2aa17dd82999dcd489ad7b057b8e4e2
(In reply to Andrey Loskutov from comment #4) > (In reply to Xi Yan from comment #3) > > This is caused by: https://git.eclipse.org/r/#/c/126598/ > > I'm sorry I have no Linux access this week. Simeon, can you please check > this? I can confirm, reverting the commit from change 126598 fixes the problem. So does applying the patch from Xi Yan (change 128655). BTW I noticed odd behaviour for the left widget of the snippet for this bug, the calendar of the GTK spin button. When clicking the plus, if the years are selected, the years go down instead of going up (by two and not by one, no less). Is this expected? Occurs both with reverted patch from bug 537364, as well as fix for this bug. GTK 3.22.10
(In reply to Simeon Andreev from comment #10) > (In reply to Andrey Loskutov from comment #4) > > (In reply to Xi Yan from comment #3) > > > This is caused by: https://git.eclipse.org/r/#/c/126598/ > > > > I'm sorry I have no Linux access this week. Simeon, can you please check > > this? > > I can confirm, reverting the commit from change 126598 fixes the problem. So > does applying the patch from Xi Yan (change 128655). > > BTW I noticed odd behaviour for the left widget of the snippet for this bug, > the calendar of the GTK spin button. When clicking the plus, if the years > are selected, the years go down instead of going up (by two and not by one, > no less). Is this expected? Occurs both with reverted patch from bug 537364, > as well as fix for this bug. > > GTK 3.22.10 That is odd, and it only happens with SWT.LONG style too. I filed a new bug 538648 for this.
Verified in I20180904-2000.
