Bug 538111 - [generic editor] Extension point for ICharacterPairMatcher
Summary: [generic editor] Extension point for ICharacterPairMatcher
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.9   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.9 RC1   Edit
Assignee: Angelo ZERR CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, noteworthy
Depends on:
Blocks:
 
Reported: 2018-08-21 05:26 EDT by Angelo ZERR CLA
Modified: 2018-08-29 07:32 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo ZERR CLA 2018-08-21 05:26:00 EDT 
It should be cool if generic editor could provide the "org.eclipse.ui.genericeditor.characterPairMatchers" extension point to contribute with IcharacterPairMatcher to manage matching brackets.

Here a sample with TM4E language configuration:

-----------------------------------------------------------------
  <extension
        point="org.eclipse.ui.genericeditor.characterPairMatchers">
     <characterPairMatcher
           class="org.eclipse.tm4e.languageconfiguration.LanguageConfigurationCharacterPairMatcher"
           contentType="org.eclipse.core.runtime.text">
        <enabledWhen>
           <with
                 variable="editor">
              <test
                    property="org.eclipse.tm4e.languageconfiguration.hasLanguageConfiguration"
                    forcePluginActivation="true">
              </test>
           </with>
        </enabledWhen>
     </characterPairMatcher>
  </extension>
-----------------------------------------------------------------

I had started something, if you like the idea, I will clean my code and create a gerrit patch.
Comment 1 Eclipse Genie CLA 2018-08-21 06:33:07 EDT 
New Gerrit change created: https://git.eclipse.org/r/127756
Comment 2 Mickael Istria CLA 2018-08-23 10:35:19 EDT 
This is a new feature and we are not in feature freeze for 4.9.
This will get in 4.10 as early as possible. In the meantime, downstream plugin can start consuming the extension point as it it were already available. As it requires no new class, it won't cause any bug.
Comment 3 Mickael Istria CLA 2018-08-24 03:34:20 EDT 
(In reply to Mickael Istria from comment #2)
> This is a new feature and we are not in feature freeze for 4.9.
> This will get in 4.10 as early as possible. In the meantime, downstream
> plugin can start consuming the extension point as it it were already
> available. As it requires no new class, it won't cause any bug.

Actually, I double checked and the API/Feature freeze is next week. I'm merging the patch.
Comment 5 Mickael Istria CLA 2018-08-24 03:48:21 EDT 
Patch merged, thanks Angelo.
Please also submit a change to the N&N before we can mark it as resolved.
Comment 6 Eclipse Genie CLA 2018-08-24 04:32:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/127986
Comment 7 Angelo ZERR CLA 2018-08-24 04:33:41 EDT 
@Mickael please merge my very simple gerrit patch https://git.eclipse.org/r/127986 because I have intriduced a bug (ex: Refactorings menu contextual is not available)
Comment 9 Eclipse Genie CLA 2018-08-24 06:11:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/128020
Comment 10 Angelo ZERR CLA 2018-08-24 06:11:36 EDT 
> Please also submit a change to the N&N before we can mark it as resolved.

Done with https://git.eclipse.org/r/#/c/128020/
Comment 11 Mickael Istria CLA 2018-08-24 06:17:16 EDT 
Thanks. This also needs to be added to the documentation bundles like other extension points.
Comment 13 Dani Megert CLA 2018-08-24 07:05:52 EDT 
(In reply to Mickael Istria from comment #11)
> Thanks. This also needs to be added to the documentation bundles like other
> extension points.

Currently the reference doc is completely missing for the generic editor. Filed bug 538238 to track that.
Comment 14 Dani Megert CLA 2018-08-28 11:59:33 EDT 
Where are we with this? Are we done for RC1?
Comment 15 Mickael Istria CLA 2018-08-28 12:05:49 EDT 
I'm keeping the bug open to track documentation, but yes, the feature is in RC1.
Comment 16 Eclipse Genie CLA 2018-08-29 07:31:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/128283
Comment 17 Mickael Istria CLA 2018-08-29 07:32:40 EDT 
Doc added