Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #535651 +++ Currently, when the tool "Link Note" is activated, if the mouse is over a Node or an Edge, there is a "forbidden" cursor (see forbiddenCursorOnNode.png). But the user can still click on the node. The representation selection dialog is opened but the OK button has no effect. The click must have no effect or be really forbidden. For a simple Note, it has no effect.
New Gerrit change created: https://git.eclipse.org/r/127336
Gerrit change https://git.eclipse.org/r/127336 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2159644d141be4af3e78f6f3fdda95ad737e9690
Steps to validate: * Open a diagram containing nodes, containers and edges. * Activate the tool "Representation Link" * Ensure that it is allowed only on diagram (forbidden on containers, nodes and edges)
It's possible to create a Representation Link on a simple container. To reproduce: - Import the use case joined - Try to use the "Representation Link" tool on the EClass, the edge or on the attribute. It's impossible. Ok - Try to use the "Representation Link" tool on the EPackage. It works and it should not! Ko
Created attachment 276130 [details] Use case to reproduce
(In reply to Julien Dupont from comment #4) > It's possible to create a Representation Link on a simple container. Sorry, what is a 'simple' container? Are there also 'complex' containers? I am not sure if the "Steps To Validate" in Comment 3 are correct. Compare this with the bug title, which sais "... on diagram or on container". Which is right now? I think Diagram + Containers is correct, because that is where 'normal' notes work can be added.
Title should be updated from > "Link Note" must be available only on diagram or on container to > "Link Note" must be available only on diagram
(In reply to Maxime Porhel from comment #7) > Title should be updated from > > "Link Note" must be available only on diagram or on container > to > > "Link Note" must be available only on diagram You're sure? Normal notes can be in a container. Why not link notes?
(In reply to Felix Dorner from comment #8) > (In reply to Maxime Porhel from comment #7) > > Title should be updated from > > > "Link Note" must be available only on diagram or on container > > to > > > "Link Note" must be available only on diagram > > You're sure? Normal notes can be in a container. Why not link notes? OK I think there is a confusion between "Container" and "Container List". Felix, in your comment bug 535651 comment c3 you said the inverse than just above. So in conclusion "Representation Link" must have the same behavior than "Note". I think that the behavior is OK but the steps to validate are wrong.
Steps to validate: * Open a diagram containing nodes, containers and edges. * Activate the tool "Representation Link" * Ensure that it is allowed only on diagram and on container (forbidden on list containers, nodes and edges)
(In reply to Laurent Redor from comment #9) > Felix, in your comment bug 535651 comment c3 you said the inverse than just > above. That was about 'classes' which are list containers, here it's 'packages' which are normal containers. So yes, there was really some confusion about these two.
Available in Sirius 6.1.0, see https://wiki.eclipse.org/Sirius/6.1.0
