Bug 535651 - "Link Note" must be available only on diagram or on container
Summary: "Link Note" must be available only on diagram or on container
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 5.1.2   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 5.1.4   Edit
Assignee: Project Inbox CLA
QA Contact: Laurent Fasani CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 537889
  Show dependency tree
 
Reported: 2018-06-07 08:42 EDT by Laurent Redor CLA
Modified: 2019-01-24 04:54 EST (History)
3 users (show)

See Also:

Attachments
forbiddenCursorOnNode.png (16.71 KB, image/png)
2018-06-07 08:42 EDT, Laurent Redor CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2018-06-07 08:42:54 EDT 
Created attachment 274372 [details]
forbiddenCursorOnNode.png

Currently, when the tool "Link Note" is activated, if the mouse is over a Node or an Edge, there is a "forbidden" cursor (see forbiddenCursorOnNode.png). But the user can still click on the node. The representation selection dialog is opened but the OK button has no effect.
The click must have no effect or be really forbidden. For a simple Note, it has no effect.
Comment 1 Felix Dorner CLA 2018-07-16 04:25:02 EDT 
I'll submit a patch shortly.
Comment 2 Eclipse Genie CLA 2018-07-16 04:45:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/126088
Comment 3 Felix Dorner CLA 2018-07-16 04:50:40 EDT 
Laurent, the title indicates that Link Note should also be available on container? I don't think this is correct, at least if the behaviour should be the same as for ordinairy notes: If I use a normal note on a Class (from the 'Design' example viewpoint) (and a class is a container, right?), I get the 'forbidden' mouse pointer. The tool should only work on the diagram canvas, and that is what my patch https://git.eclipse.org/r/#/c/126088/ fixes.
Comment 5 Laurent Redor CLA 2018-09-25 06:32:05 EDT 
Steps to validate:
* Open a diagram containing nodes, containers and edges.
* Activate the tool "Representation Link"
* Ensure that it is allowed only on diagram (forbidden on containers, nodes and edges)
Comment 6 Laurent Fasani CLA 2018-12-06 04:07:42 EST 
"Representation Link" is allowed on container. It is possible to click on a container and the note is effectively created inside the container
Comment 7 Felix Dorner CLA 2018-12-06 04:17:15 EST 
(In reply to Laurent Fasani from comment #6)
> "Representation Link" is allowed on container. It is possible to click on a
> container and the note is effectively created inside the container

Comment 5 is incorrect. See Comment 10 here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=537889#c10
Comment 8 Laurent Redor CLA 2018-12-06 05:38:11 EST 
Yes I confirm what is said by Felix. I forgot to write here the new steps to validate from bug 537889 comment 10.
Comment 9 Laurent Fasani CLA 2018-12-06 05:41:03 EST 
all right. It is verified then ;) with Sirius5.1.420180512
Comment 10 Pierre-Charles David CLA 2019-01-24 04:54:04 EST 
Available in Sirius 5.1.4, see https://wiki.eclipse.org/Sirius/5.1.4 for details.