Bug 537639 - Disabled tests 16 Platform UI Junit tests in org.eclipse.e4.ui.tests fail on Mac
Summary: Disabled tests 16 Platform UI Junit tests in org.eclipse.e4.ui.tests fail on Mac
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.9   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 546584 (view as bug list)
Depends on:
Blocks: 549374
  Show dependency tree
 
Reported: 2018-08-03 02:14 EDT by Kalyan Prasad Tatavarthi CLA
Modified: 2022-05-13 06:47 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan Prasad Tatavarthi CLA 2018-08-03 02:14:35 EDT
16 platform UI tests in org.eclipse.e4.ui.tests fail only on Mac.

1) testBug326175_False	Error	expected:<PartImplContext> but was:<null> 

java.lang.AssertionError: expected:<PartImplContext> but was:<null>
at org.eclipse.e4.ui.tests.workbench.PartRenderingEngineTests.testBug326175(PartRenderingEngineTests.java:2170)

2) testBug324839	Error	Application does not have an active window 

java.lang.IllegalStateException: Application does not have an active window
at org.eclipse.e4.ui.internal.workbench.ApplicationPartServiceImpl.getActiveWindowService(ApplicationPartServiceImpl.java:39)

3) testBug372226	Error	Application does not have an active window 

java.lang.IllegalStateException: Application does not have an active window
at org.eclipse.e4.ui.internal.workbench.ApplicationPartServiceImpl.getActiveWindowService(ApplicationPartServiceImpl.java:39)

4) testCreateWindow	Error	expected:<Shell {MyWindow}> but was:<null> 

java.lang.AssertionError: expected:<Shell {MyWindow}> but was:<null>
at org.eclipse.e4.ui.tests.workbench.MWindowTest.testCreateWindow(MWindowTest.java:112)

5) testContextChildren	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.MWindowTest.testContextChildren(MWindowTest.java:208)

6) testHandlerInActivePartOnly	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInActivePartOnly(HandlerActivationTest.java:170)

7) testHandlerInWindowOnly	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInWindowOnly(HandlerActivationTest.java:156)

8) testHandlerSwitchToInactivePartInOtherPerspectiveWithPartHandlers	Error	Application does not have an active window 

java.lang.IllegalStateException: Application does not have an active window
at org.eclipse.e4.ui.internal.workbench.ApplicationPartServiceImpl.getActiveWindowService(ApplicationPartServiceImpl.java:39)

9) testHandlerInActivePerspectiveAndWindow	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInActivePerspectiveAndWindow(HandlerActivationTest.java:210)

10) testHandlerInActivePerspectiveOnly	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInActivePerspectiveOnly(HandlerActivationTest.java:163)

11) testHandlerSwitchToInactivePartInOtherPerspectiveWithPerspectiveHandlers	Error	Application does not have an active window 

java.lang.IllegalStateException: Application does not have an active window
at org.eclipse.e4.ui.internal.workbench.ApplicationPartServiceImpl.getActiveWindowService(ApplicationPartServiceImpl.java:39)

12) testHandlerInActivePartAndPerspectiveAndWindow	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInActivePartAndPerspectiveAndWindow(HandlerActivationTest.java:220)

13) testHandlerSwitchToInactivePart	Error	Application does not have an active window 

java.lang.IllegalStateException: Application does not have an active window
at org.eclipse.e4.ui.internal.workbench.ApplicationPartServiceImpl.getActiveWindowService(ApplicationPartServiceImpl.java:39)

14) testHandlerInActivePartAndWindow	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInActivePartAndWindow(HandlerActivationTest.java:201)

15) testHandlerInActivePartAndPerspective	Error	N/A 

java.lang.AssertionError
at org.eclipse.e4.ui.tests.workbench.HandlerActivationTest.testHandlerInActivePartAndPerspective(HandlerActivationTest.java:192)

16) testHandlerSwitchToInactivePerspective	Error	Application does not have an active window 

java.lang.IllegalStateException: Application does not have an active window
at org.eclipse.e4.ui.internal.workbench.ApplicationPartServiceImpl.getActiveWindowService(ApplicationPartServiceImpl.java:39)
Comment 1 Kalyan Prasad Tatavarthi CLA 2018-08-03 02:15:02 EDT
All these tests pass locally on Mac.
Comment 2 Kalyan Prasad Tatavarthi CLA 2019-04-25 06:45:17 EDT
*** Bug 546584 has been marked as a duplicate of this bug. ***
Comment 3 Rolf Theunissen CLA 2019-07-19 05:47:06 EDT
I have been struggling with focus on the Mac test servers before, and gave up by disabling these test on Mac, see Bug 297510.
I remember seeing more comments about focus issues in on Mac in the SWT test.

When running the E4 test suite on Windows OS, I see that some windows are only closed when the test suite finishes. That is, some windows seem to hang until the tests are finished. I did see something similar with the SWT test cases. I think that could be related.
It is however very difficult (for me) to find out which test cases did not clean up the windows correctly.
Comment 4 Eclipse Genie CLA 2020-01-27 03:16:17 EST
New Gerrit change created: https://git.eclipse.org/r/156605
Comment 6 Kalyan Prasad Tatavarthi CLA 2020-01-27 06:48:19 EST
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/156605 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=5a90b5dcddec243e02ea7e0b7d0c3100d9a20db9

This commit disables these 16 tests on Mac.
Comment 7 Eclipse Genie CLA 2020-01-28 06:33:29 EST
New Gerrit change created: https://git.eclipse.org/r/156706
Comment 9 Kalyan Prasad Tatavarthi CLA 2020-01-28 06:47:01 EST
(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/156706 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=80454531524a8bd9ba149690cb7c09ac84f97b2e

this commit skips these 16 tests on Mac using org.junit.Assume
Comment 10 Rolf Theunissen CLA 2020-11-22 11:10:35 EST
The issues with respect to HandlerActivationTest might be solved by the patch for Bug 566172