Bug 536938 - [Project Explorer] Filters and Customization view looks bad in dark theme
Summary: [Project Explorer] Filters and Customization view looks bad in dark theme
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.9   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2018-07-12 04:39 EDT by Dawid Pakula CLA
Modified: 2019-12-25 08:57 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2018-07-12 04:39:49 EDT 
As in subject, just open this view in dark theme. These light borders are unnecessary.
Comment 1 Lars Vogel CLA 2018-11-27 10:28:18 EST 
Dawid, could you provide a Gerrit.
Comment 2 Jose Probst CLA 2019-07-10 10:10:51 EDT 
Calling setBackground(Color) in CommonFiltersTab#createControl would do the job, but I couldn't figure out which color should be used.
I used:
PlatformUI.getWorkbench().getThemeManager().getCurrentTheme().getColorRegistry().get(someString) to obtain some colors, but none of them really suited all cases.

e.g. "org.eclipse.ui.workbench.INFORMATION_BACKGROUND" was fine with the dark-theme but was completely wrong with the light-theme.

So 2 Questions:

Is it a good idea to set the background color in the CommonFilterTab?

If yes, which Color constant would be correct?
Comment 3 Dawid Pakula CLA 2019-12-25 08:57:38 EST 
Looks fine on 2019-12. Marking as resolved.