Bug 536017 - [GTK] Shell.setFullScreen broken for Modeless window
Summary: [GTK] Shell.setFullScreen broken for Modeless window
Status: CLOSED DUPLICATE of bug 530841
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.9   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 530841
  Show dependency tree
 
Reported: 2018-06-18 13:00 EDT by Oleksandr Kozlov CLA
Modified: 2018-07-12 10:08 EDT (History)
2 users (show)

See Also:


Attachments
Patch with possible solution (2.45 KB, patch)
2018-06-18 13:29 EDT, Oleksandr Kozlov CLA
no flags Details | Diff
Possible snippet to reproduce the issue (1008 bytes, text/x-java)
2018-06-18 14:02 EDT, Eric Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksandr Kozlov CLA 2018-06-18 13:00:17 EDT
[GTK] Shell.setFullScreen broken for Modeless window
Comment 1 Oleksandr Kozlov CLA 2018-06-18 13:09:23 EDT
Workflow:

1.) Launch application. 

2.) Toggle On Full Screen Mode

3.) Open modeless dialog with styles that differ from "SWT.PRIMARY_MODAL | SWT.APPLICATION_MODAL | SWT.SYSTEM_MODAL"

For example: "SWT.CLOSE | SWT.MODELESS| SWT.BORDER | SWT.TITLE"

Observed result: Pop up window hide in background in fullscreen mode and not usable.
Comment 2 Oleksandr Kozlov CLA 2018-06-18 13:29:13 EDT
Created attachment 274512 [details]
Patch with possible solution
Comment 3 Eric Williams CLA 2018-06-18 13:47:04 EDT
Thanks, I'll take a look.
Comment 4 Eric Williams CLA 2018-06-18 14:02:31 EDT
Created attachment 274513 [details]
Possible snippet to reproduce the issue

Please let me know if the attached snippet reproduces the bug on your system. Also, please provide the following:

GTK3 version
Eclipse/SWT version
OS
Comment 5 Oleksandr Kozlov CLA 2018-06-19 07:10:16 EDT
I'm able to reproduce this bug with attached snipped on my system.

I'm using:

GTK3 is not installed
GTK2 gtk2-2.24.23-6.el6.x86_64
Eclipse RCP Neon 3.Release (4.6.3)
SWT ------ 
OS Redhat 6.6 (Santiago)
Comment 6 Eric Williams CLA 2018-06-19 11:54:47 EDT
(In reply to Oleksandr Kozlov from comment #5)
> I'm able to reproduce this bug with attached snipped on my system.
> 
> I'm using:
> 
> GTK3 is not installed
> GTK2 gtk2-2.24.23-6.el6.x86_64
> Eclipse RCP Neon 3.Release (4.6.3)
> SWT ------ 
> OS Redhat 6.6 (Santiago)

Neon is no longer supported, and Red Hat 6 is also no longer a supported environment.

I cannot reproduce the issue on GTK2.24 on my system, nor can I on GTK3. If you can reproduce this bug on a supported environments [1] [2] using 4.7 or 4.8, I'd be happy to take a look.

1: https://www.eclipse.org/projects/project-plan.php?planurl=http://www.eclipse.org/eclipse/development/plans/eclipse_project_plan_4_7.xml#target_environments

2: https://www.eclipse.org/projects/project-plan.php?planurl=http://www.eclipse.org/eclipse/development/plans/eclipse_project_plan_4_8.xml#target_environments

Please also note that SWT under GTK2 is no longer actively under development (see bug 530841). I'm happy to accept GTK2 patches (like you have provided), but if there are bugs stopping you from using GTK3, please file them as GTK2 support isn't guaranteed to be around for much longer.
Comment 7 Eric Williams CLA 2018-07-10 13:57:55 EDT
Please note: GTK2 support for SWT is being dropped in Eclipse 4.10 / SimRel 2018-12 release. 

See the following mail for more info: http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg15783.html
Comment 8 Alexander Kurtakov CLA 2018-07-12 10:08:15 EDT
Marking the bug as duplicate of the GTK2 tracker as no work for GTK2 issues will happen. Please reopen if you still face the issue using GTK 3.x.

*** This bug has been marked as a duplicate of bug 530841 ***