Community
Participate
Working Groups
Created attachment 274421 [details] Screenshot: Profiler - Blocked Threads Searched for "\n" for "*.java" files in a huge workspace (wanted a simple LOC stats). Since the search took a long time I took a profile and saw many blocking situations in org.eclipse.search.internal.ui.text.FileSearchQuery$TextSearchResultCollector.acceptPatternMatch(TextSearchMatchAccess) FileSearchQuery.java:116 Also some hot spots are: - org.eclipse.search.internal.ui.text.FileTreeContentProvider.elementsChanged(Object[]) - org.eclipse.search.ui.text.AbstractTextSearchResult.getMatches(Object) AbstractTextSearchResult.java
Created attachment 274422 [details] Screenshot: Profiler - Hot Spot
Created attachment 274423 [details] Screenshot: Profiler - Hot Spot 2
At least on Windows the main issue here is the refresh of the viewer. Many of the jface viewers perform really bad when refreshing often or on big contents (which is the case here). I'll attach a patch to avoid the structure refresh of the viewer. For me that makes a huge difference: A search with more than 500.000 results previously took 3 minutes to display, now that is 3 seconds. Karsten, please check if that also leads to improvements on your Mac.
New Gerrit change created: https://git.eclipse.org/r/129833
Gerrit change https://git.eclipse.org/r/129833 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c830a13682e366a197a96dfe1b7ae47053a2673a
Thanks, Michael!
Sorry for reopening, the blocking still remains.
Michael, can you take a look? Whoever wants to work on this, please set the target milestone again.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
