Bug 535597 - W[GTK3] Tool bars Icons seem too close each other on Ubuntu 18.04
Summary: W[GTK3] Tool bars Icons seem too close each other on Ubuntu 18.04
Status: CLOSED NOT_ECLIPSE
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-06-06 09:23 EDT by Alessandro Fardin CLA
Modified: 2018-06-08 10:11 EDT (History)
2 users (show)

See Also:

Attachments
icon too closer in ubuntu 18.4 (167.13 KB, image/png)
2018-06-06 09:32 EDT, Alessandro Fardin CLA 		no flags Details
Close toolbar icons with default GTK theme on Ubuntu 18.04 (20.38 KB, image/png)
2018-06-06 09:55 EDT, Peter Severin CLA 		no flags Details
screenshot of eclipse on ubuntu 18.04 with theme adwaita (168.26 KB, image/png)
2018-06-06 12:09 EDT, Alessandro Fardin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Fardin CLA 2018-06-06 09:23:04 EDT 
In ubuntu 18.04 the icons in the tool bar and in the view seem too cloese each other to me.
follow screeshot...


-- Configuration Details --
Product: Eclipse IDE 4.8.0.20180531-0839 (org.eclipse.epp.package.cpp.product)Installed Features:
 org.eclipse.platform 4.8.0.v20180524-1240
Comment 1 Alessandro Fardin CLA 2018-06-06 09:32:33 EDT 
Created attachment 274351 [details]
icon too closer in ubuntu 18.4
Comment 2 Eric Williams CLA 2018-06-06 09:46:58 EDT 
What GTK theme are you using?
Comment 3 Peter Severin CLA 2018-06-06 09:55:12 EDT 
Created attachment 274352 [details]
Close toolbar icons with default GTK theme on Ubuntu 18.04

I see this issue with default theme on Ubuntu 18.04. From the screenshot it can be seen that on mouse over the highlighted icon has no or minimal padding.
Comment 4 Alessandro Fardin CLA 2018-06-06 09:56:53 EDT 
Hi Erik I'm using a standard ubuntu 18.04 box: GTK 3.22.30
Comment 5 Eric Williams CLA 2018-06-06 10:17:24 EDT 
Default Ubuntu theme is Ambiance, correct? Would it be possible to try with Adwaita? We have some toolbar padding logic in SWT but it's dependent on the theme.
Comment 6 Alessandro Fardin CLA 2018-06-06 11:11:55 EDT 
Hi Erik I can say that the problem is not present using  eclipse photon on ubuntu 16.04 (gtk 3.18 theme Ambiance)
Comment 7 Alessandro Fardin CLA 2018-06-06 12:08:10 EDT 
I've made a test with ubuntu 18.04 with adwaita theme:
Icons now have the right space.
so the problem is in ambience theme
Comment 8 Alessandro Fardin CLA 2018-06-06 12:09:55 EDT 
Created attachment 274354 [details]
screenshot of eclipse on ubuntu 18.04 with theme adwaita

with awaita icons space is correct
Comment 9 Eric Williams CLA 2018-06-06 16:46:49 EDT 
(In reply to Alessandro Fardin from comment #8)
> Created attachment 274354 [details]
> screenshot of eclipse on ubuntu 18.04 with theme adwaita
> 
> with awaita icons space is correct

Probably an issue with the Ubuntu Ambiance theme then. Does the issue occur on an older version of Eclipse (like 4.7)?
Comment 10 Alessandro Fardin CLA 2018-06-07 11:30:20 EDT 
Eclipse 4.7.3 (oxygen.3) in ubuntu 18.04 has the same issue
Comment 11 Eric Williams CLA 2018-06-08 10:11:47 EDT 
(In reply to Alessandro Fardin from comment #10)
> Eclipse 4.7.3 (oxygen.3) in ubuntu 18.04 has the same issue

Okay this is an Ubuntu theming issue then. Not much we can do from SWT's POV -- it might be worth raising a bug with Ubuntu about this.