Community
Participate
Working Groups
All repositories need a NOTICE and LICENSE file. For details see bug 535136 comment 2.
There are plans for this. Will revisit in 4.10
will look into this in RC1
New Gerrit change created: https://git.eclipse.org/r/127990
New Gerrit change created: https://git.eclipse.org/r/127991
New Gerrit change created: https://git.eclipse.org/r/127992
New Gerrit change created: https://git.eclipse.org/r/127993
New Gerrit change created: https://git.eclipse.org/r/127994
New Gerrit change created: https://git.eclipse.org/r/127995
New Gerrit change created: https://git.eclipse.org/r/127996
New Gerrit change created: https://git.eclipse.org/r/127997
New Gerrit change created: https://git.eclipse.org/r/127998
New Gerrit change created: https://git.eclipse.org/r/127999
New Gerrit change created: https://git.eclipse.org/r/128000
New Gerrit change created: https://git.eclipse.org/r/128001
New Gerrit change created: https://git.eclipse.org/r/128002
New Gerrit change created: https://git.eclipse.org/r/128003
New Gerrit change created: https://git.eclipse.org/r/128004
New Gerrit change created: https://git.eclipse.org/r/128005
New Gerrit change created: https://git.eclipse.org/r/128006
New Gerrit change created: https://git.eclipse.org/r/128007
New Gerrit change created: https://git.eclipse.org/r/128008
New Gerrit change created: https://git.eclipse.org/r/128010
New Gerrit change created: https://git.eclipse.org/r/128009
New Gerrit change created: https://git.eclipse.org/r/128011
New Gerrit change created: https://git.eclipse.org/r/128012
New Gerrit change created: https://git.eclipse.org/r/128013
New Gerrit change created: https://git.eclipse.org/r/128014
New Gerrit change created: https://git.eclipse.org/r/128015
@Dani, Can you please review these patches?
(In reply to Sravan Kumar Lakkimsetti from comment #29) > @Dani, > > Can you please review these patches? Did you create the files manually or with a tool? For example I see ISpell mentioned in the JDT Core repository, but it's (only) in JDT UI. Maybe Alex can review it since he already did this for RT (without p2).
I may look at this one only after fixing jdt.debug tests and the rest of epl 2 patches.
I created these files with the tool https://www.eclipse.org/projects/tools/documentation.php From the eclipse project point of view we have 4 projects with multiple repositories. 1. JDT 2. PDE 3. Equinox and 4. Platform accordingly the documentation has been generated by the Legal Documentation Generator available here https://www.eclipse.org/projects/tools/documentation.php. I am not sure if we need to customize for individual git repos.
(In reply to Alexander Kurtakov from comment #31) > I may look at this one only after fixing jdt.debug tests and the rest of epl > 2 patches. That would be great!
(In reply to Sravan Kumar Lakkimsetti from comment #32) > I created these files with the tool > https://www.eclipse.org/projects/tools/documentation.php The generator is marked experimental and says: Some information may be missing; it is ultimately the project team's responsibility to provide this information. I assume you did not validate the generated stuff, because that is a lot of work. I think we should go back to Wayne and ask how experimental the tool really is these days. > From the eclipse project point of view we have 4 projects with multiple > repositories. > > 1. JDT > 2. PDE > 3. Equinox and > 4. Platform OK.
(In reply to Dani Megert from comment #33) > (In reply to Alexander Kurtakov from comment #31) > > I may look at this one only after fixing jdt.debug tests and the rest of epl > > 2 patches. > > That would be great! Yeah, but it may mean post RC1 as there is a lot of EPL 2 stuff pending.
(In reply to Alexander Kurtakov from comment #35) > (In reply to Dani Megert from comment #33) > > (In reply to Alexander Kurtakov from comment #31) > > > I may look at this one only after fixing jdt.debug tests and the rest of epl > > > 2 patches. > > > > That would be great! > > Yeah, but it may mean post RC1 as there is a lot of EPL 2 stuff pending. When you did it for Equinox, did you verify all the generated files?
(In reply to Dani Megert from comment #36) > (In reply to Alexander Kurtakov from comment #35) > > (In reply to Dani Megert from comment #33) > > > (In reply to Alexander Kurtakov from comment #31) > > > > I may look at this one only after fixing jdt.debug tests and the rest of epl > > > > 2 patches. > > > > > > That would be great! > > > > Yeah, but it may mean post RC1 as there is a lot of EPL 2 stuff pending. > > When you did it for Equinox, did you verify all the generated files? I don't remember doing it for Equinox nor I can see these files in p2 repo.
(In reply to Alexander Kurtakov from comment #37) > (In reply to Dani Megert from comment #36) > > (In reply to Alexander Kurtakov from comment #35) > > > (In reply to Dani Megert from comment #33) > > > > (In reply to Alexander Kurtakov from comment #31) > > > > > I may look at this one only after fixing jdt.debug tests and the rest of epl > > > > > 2 patches. > > > > > > > > That would be great! > > > > > > Yeah, but it may mean post RC1 as there is a lot of EPL 2 stuff pending. > > > > When you did it for Equinox, did you verify all the generated files? > > I don't remember doing it for Equinox nor I can see these files in p2 repo. I guess you refer to http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/CONTRIBUTING?id=a81821be15dd8130d1976c11d7a30488c58c3514 but it was simply fixing URL, nothing more.
(In reply to Alexander Kurtakov from comment #38) > (In reply to Alexander Kurtakov from comment #37) > > (In reply to Dani Megert from comment #36) > > > (In reply to Alexander Kurtakov from comment #35) > > > > (In reply to Dani Megert from comment #33) > > > > > (In reply to Alexander Kurtakov from comment #31) > > > > > > I may look at this one only after fixing jdt.debug tests and the rest of epl > > > > > > 2 patches. > > > > > > > > > > That would be great! > > > > > > > > Yeah, but it may mean post RC1 as there is a lot of EPL 2 stuff pending. > > > > > > When you did it for Equinox, did you verify all the generated files? > > > > I don't remember doing it for Equinox nor I can see these files in p2 repo. > > I guess you refer to > http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/CONTRIBUTING?id=a81821be15dd8130d1976c11d7a30488c58c3514 > > but it was simply fixing URL, nothing more. Indeed.
Sravan, can you please ask Wayne regarding the tool? It doesn't look feasible to verify the generated files manually against all our projects.
@wayne, I generated the required files using the tool at https://www.eclipse.org/projects/tools/documentation.php. There are some questions regarding this tool and general update for the repos. 1. How accurate is the tool. like what kind of information is missing? 2. There are 4 top level projects for SDK with multiple repositories. My plan is to use same legal documentation for all the repositories under that project. There are some issues here. like the one mentioned by Dani in comment 30. How to proceed on this. 3. Do we need to individually tailor this legal documentation for the individual repos?
(In reply to Sravan Kumar Lakkimsetti from comment #41) > 1. How accurate is the tool. like what kind of information is missing? The tool is as accurate the the underlying data that drives it. It gets the project description, for example, from the PMI. If you want to change what gets generated, you can make the change in the PMI. As you've likely noticed, the generator doesn't handle the project roll up (i.e. the generated NOTICE file for the TLP doesn't include any information from subprojects). So, some customization is required for projects that have subprojects. Just drop the section on third party content; that information will be captured in your about.html files already, so it's not strictly needed here as well (keeping that up to date in the NOTICE will be a painful challenge). > 2. There are 4 top level projects for SDK with multiple repositories. My > plan is to use same legal documentation for all the repositories under that > project. There are some issues here. like the one mentioned by Dani in > comment 30. How to proceed on this. I think that dropping the third party content section addresses Dani's question. Correct me if I'm wrong. > 3. Do we need to individually tailor this legal documentation for the > individual repos? I think that you really want to. Updating a dozen of these files is going to be painful. If you take out the third party content list, I think that you can make a single file work. I think that the main challenge is going to be keeping the list of repositories up-to-date. I see that you've provided a list; that should work for now. I've opened Bug 538313; once we address that you can just provide a link to the "Developer Resources" page and--as long as the project metadata is maintained--you'll always have an up-to-date list. Thanks for addressing this.
(In reply to Wayne Beaton from comment #42) > > 3. Do we need to individually tailor this legal documentation for the > > individual repos? > > I think that you really want to. Updating a dozen of these files is going to > be painful. If you take out the third party content list, I think that you > can make a single file work. I'm not sure I understood. Did you want to say "I DONT'T think..."? Or did you mean that we have to tailor one file to match everything? Can we move this to 4.10?
(In reply to Dani Megert from comment #43) > (In reply to Wayne Beaton from comment #42) > > > 3. Do we need to individually tailor this legal documentation for the > > > individual repos? > > > > I think that you really want to. Updating a dozen of these files is going to > > be painful. If you take out the third party content list, I think that you > > can make a single file work. > > I'm not sure I understood. Did you want to say "I DONT'T think..."? Or did > you mean that we have to tailor one file to match everything? It appears that I mistyped. My apologies. One common set of files seems easier for everybody. > Can we move this to 4.10? Yes.
Sravan please work on this for 4.10 along the lines given by Wayne.
@wayne, I used https://www.eclipse.org/projects/tools/documentation.php to generate these files. Shall I proceed with dropping third party content from the notice file? If so then we need to fix the tool as well as the tool generetaes all the third party content into notice file
(In reply to Sravan Kumar Lakkimsetti from comment #46) > @wayne, > > I used https://www.eclipse.org/projects/tools/documentation.php to generate > these files. > > Shall I proceed with dropping third party content from the notice file? If > so then we need to fix the tool as well as the tool generetaes all the third > party content into notice file @wayne, Can you please let me know whether I can proceed with this?
(In reply to Sravan Kumar Lakkimsetti from comment #46) > Shall I proceed with dropping third party content from the notice file? Yes. > If > so then we need to fix the tool as well as the tool generetaes all the third > party content into notice file The tool is intended to provide a template. The current implementation is appropriate for projects that do not build Eclipse Platform plug-ins and so do not have this information captured elsewhere. I'll see what I can do (time permitting). In the meantime, I'll add some instructions to the generator to remind committers that the content can and should be tuned for specific circumstances.
New Gerrit change created: https://git.eclipse.org/r/132430
New Gerrit change created: https://git.eclipse.org/r/132431
New Gerrit change created: https://git.eclipse.org/r/132432
Gerrit change https://git.eclipse.org/r/127990 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=430e06b717310c392abb24177c3c0a23241aab88
Gerrit change https://git.eclipse.org/r/132432 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.binaries.git/commit/?id=55a02d99cce425b3a4b36a1ef6799e8e93d08261
Gerrit change https://git.eclipse.org/r/132431 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=dceccd3932522a393791b7dca4bf781e288ec978
Gerrit change https://git.eclipse.org/r/132430 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=fbdd73445a236c8ee497f16fc411b7372ecd70e0
Gerrit change https://git.eclipse.org/r/128015 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.buildtools.git/commit/?id=38dc9011ee3e20eaf82bc2a9628fe0d3db5aeacc
Gerrit change https://git.eclipse.org/r/128009 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=31bc4484cb5f2855c62204b3cc3b9bc6d4ff7f49
Gerrit change https://git.eclipse.org/r/127997 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9b807b3f87a756c5ba08b0fb1f4c55e7e2524369
Gerrit change https://git.eclipse.org/r/127996 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=8d9f9464683f0197e5847194673898b47045f4d0
Gerrit change https://git.eclipse.org/r/128006 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=08b77e0b7654a06df0dc8b190a18ce69545ac311
Gerrit change https://git.eclipse.org/r/128007 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=1451c934039475c4415853cc28613c5c16e357f4
Gerrit change https://git.eclipse.org/r/128008 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=b4361a89654c64dfcc0ebef8d25ada3c0f6ac3d0
Gerrit change https://git.eclipse.org/r/128010 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=f37c9d4765e1d65077b4e762f11d1f431dda3efd
Gerrit change https://git.eclipse.org/r/127998 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=4f0b998a74a0e53ec17ed7f4af48a9afa4e9a919
Gerrit change https://git.eclipse.org/r/127999 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=78b0ee4fbe152eca8a54e26f713afe4f22c103ce
Gerrit change https://git.eclipse.org/r/128005 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?id=9987f7caced14f3a80390ab91da4c916016e873d
Gerrit change https://git.eclipse.org/r/128000 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=48e1766b618fa383514aa2ed6b0ef17bdb9e6047
Gerrit change https://git.eclipse.org/r/128004 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3be3f5e1500eefbd4823d95391295eeebe2784c7
Gerrit change https://git.eclipse.org/r/128001 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=ff17bf9de61fc1ece7a28155192edaa1955c6990
Gerrit change https://git.eclipse.org/r/128002 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=a466f0d72d1914cd03f87fca7021cd3548d73e29
Gerrit change https://git.eclipse.org/r/128003 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=f22eaad21163636c94e271f03c0fd4a0d8bbd1e3
Gerrit change https://git.eclipse.org/r/127991 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.git/commit/?id=d211af9c603616d28347a58cc0bc136dbe566aa1
Gerrit change https://git.eclipse.org/r/127992 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=299476ded83d2b23da044bfa8a9a82012881d3c2
Gerrit change https://git.eclipse.org/r/128011 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=feddc5ef3fd4bfe685d7adef3f61cf3432c878cd
Gerrit change https://git.eclipse.org/r/128012 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=91a2401c8c0b590d8729c62472c0a5bab7adbd54
Gerrit change https://git.eclipse.org/r/128013 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=4dd656679b7a358bdbc18d11caccbdf7efe0f1bd
Gerrit change https://git.eclipse.org/r/128014 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=e56af434c7f7926d52b2c4e57bf5e5fd8cd35e57
Updated the necessary legal documentation on all the repos. Used https://www.eclipse.org/projects/tools/documentation.php tool to generate necessary documentation
A bit late, but should `NOTICE` and `CONTRIBUTING` have the file extension `.md`? Both seem to contain Markdown content. This would make editing them easier, and would make it easier to read them in the IDE or browser (at least for Eclipse projects hosted / mirrored to GitHub, such as JDT). If possible it might also be good to replace the HTTP URLs in `NOTICE` and `CONTRIBUTING` with HTTPS URLs (and update the tool which generated these URLs). (Though I can't make that change since I have not signed the ECA and am not familiar with the workflows of the projects.)
