Bug 535267 - [9] Help contexts for new dialogs relating to modularity details
Summary: [9] Help contexts for new dialogs relating to modularity details
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.9 RC1   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on: 519444 521663
Blocks:
  Show dependency tree
 
Reported: 2018-05-29 06:39 EDT by Dani Megert CLA
Modified: 2018-08-30 01:10 EDT (History)
6 users (show)

See Also:
sarika.sinha: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2018-05-29 06:39:18 EDT 
+++ This bug was initially created as a clone of Bug #521663 +++

Dialogs introduced for bug 519444 have FIXMEs in their code because they don't yet set the correct help context - because such context has not yet been created, content still needs to be authored.
Comment 1 Eclipse Genie CLA 2018-08-27 05:12:14 EDT 
New Gerrit change created: https://git.eclipse.org/r/128116
Comment 2 Eclipse Genie CLA 2018-08-27 05:17:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/128117
Comment 3 Stephan Herrmann CLA 2018-08-27 05:26:25 EDT 
Sarika, may I ask your +1 for inclusion in RC1?

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/128116

This is the code change in JDT/UI.

(In reply to Eclipse Genie from comment #2)
> New Gerrit change created: https://git.eclipse.org/r/128117

This is stub content in the doc bundle.

I hope it's OK to only have the trivial code change reviewed, as I'm planning to write the real content later today, when you may already have left the office ...

One tiny issue in the HTML: I inserted a link to the JPMS JSR, but this doesn't work in the help window on my linux box. Only if I say "open in new window", it opens, in a near-zero-sized window, which after enlarging shows the correct content. Is that a bug in the help system - me doing s.t. wrong - or a quirk of that particular page? Any idea? Does it work on other platforms?
Comment 4 Sarika Sinha CLA 2018-08-27 05:55:41 EDT 
+1 for JDT UI Changes.

JDT Doc changes does not require +1 for RC1, you can release the changes.

I tried out the jdt doc patch, I was able to click the link for 
<a href="http://openjdk.java.net/projects/jigsaw/spec"> and it opened properly on Windows.
Comment 6 Stephan Herrmann CLA 2018-08-27 15:15:27 EDT 
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/128117 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/
> ?id=4534e050ac2053e156d7d4d65f52d41e46314d58

Completed doc content.
Comment 8 Stephan Herrmann CLA 2018-08-27 15:26:10 EDT 
(In reply to Sarika Sinha from comment #4)
> +1 for JDT UI Changes.

Thanks, Sarika,

After rebase I directly pushed:

(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/128116 was merged to [master].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/
> ?id=34920635774c895c5db6656e9c9936592c33e12e

gerrit queue is totally jammed, apparently a flood of EPL 2.0 changes,
but we already had a successful build :)


BTW: comments on the documentation are of course welcome, too.
Comment 9 Sarika Sinha CLA 2018-08-28 04:39:19 EDT 
Looks Good Stephan!!
Regarding --add-reads - 
In other words: the source module will be made to "read" the target module.

Not sure, but "made to read" somehow struck me -
In other words: the target module will be made available for "read" for the source module.

Is that what you meant?
Comment 10 Sarika Sinha CLA 2018-08-30 01:10:26 EDT 
Verified using
Eclipse SDK

Version: 2018-09 (4.9)
Build id: I20180829-2000