Bug 521663 - [9] Help contexts for new dialogs relating to modularity details
Summary: [9] Help contexts for new dialogs relating to modularity details
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.8 RC3   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on: 519444
Blocks: 535267
  Show dependency tree
 
Reported: 2017-08-31 06:28 EDT by Stephan Herrmann CLA
Modified: 2018-05-29 06:40 EDT (History)
6 users (show)

See Also:
daniel_megert: review+
manoj.palat: review+
niraj.modi: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2017-08-31 06:28:39 EDT 
Dialogs introduced for bug 519444 have FIXMEs in their code because they don't yet set the correct help context - because such context has not yet been created, content still needs to be authored.
Comment 1 Noopur Gupta CLA 2017-08-31 10:55:54 EDT 
We should probably disable the help until this is fixed. 

The help page for "Module properties" dialog currently gives incorrect information: "This dialog allows you to configure access rules."
Comment 2 Stephan Herrmann CLA 2017-08-31 13:51:23 EDT 
(In reply to Noopur Gupta from comment #1)
> We should probably disable the help until this is fixed. 
> 
> The help page for "Module properties" dialog currently gives incorrect
> information: "This dialog allows you to configure access rules."

Sounds good. How do I do that?
I only found how I could get help to say "The context help for this user interface element could not be found.".
Can I (easily) disable the help button altogether?
Comment 3 Noopur Gupta CLA 2017-09-01 01:42:52 EDT 
TrayDialog.setHelpAvailable(boolean helpAvailable) should work.
Comment 4 Stephan Herrmann CLA 2017-09-26 17:12:23 EDT 
Sorry, ran out of time for 4.7.1a.
Comment 5 Stephan Herrmann CLA 2017-12-03 17:50:59 EST 
I'm running out of time for M4 - bulk move to M5
Comment 6 Sarika Sinha CLA 2018-03-02 07:08:00 EST 
Taking care of triaging, Ok to move to M7?
Comment 7 Stephan Herrmann CLA 2018-03-04 13:18:11 EST 
bulk move to 4.8 M7
Comment 8 Dani Megert CLA 2018-05-23 09:16:18 EDT 
Stephan do you still plan to deliver this for 4.8?
Comment 9 Dani Megert CLA 2018-05-28 12:08:51 EDT 
(In reply to Dani Megert from comment #8)
> Stephan do you still plan to deliver this for 4.8?

PING!
Comment 10 Stephan Herrmann CLA 2018-05-28 19:55:28 EDT 
(In reply to Dani Megert from comment #9)
> (In reply to Dani Megert from comment #8)
> > Stephan do you still plan to deliver this for 4.8?
> 
> PING!

Sorry, I didn't find the time for it.

So, for 4.8, should we just disable the button using comment 3?
The current link is obviously wrong and thus worse than no link at all.
Comment 11 Eclipse Genie CLA 2018-05-28 20:06:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/123497
Comment 12 Eclipse Genie CLA 2018-05-29 06:24:17 EDT 
Gerrit change https://git.eclipse.org/r/123497 was merged to [R4_8_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=2ac28d551c5c70a892b95ebb22f16b7c60d9dc99
Comment 13 Dani Megert CLA 2018-05-29 06:40:51 EDT 
Cherry-picked to master with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1b7b7b416b60a7fd6a40cf77847dedeb305afb1a


Filed bug 535267 to track the real fix.