Comment 1 Wim Jongman 2018-05-23 06:05:18 EDT

you mean "drink our own champagne"?

Comment 2 Dani Megert 2018-05-23 06:34:58 EDT

Definitely too late for 4.8. We can see how the feedback is from the Java package and then decide during 4.9.

Comment 3 Thomas Schindl 2018-05-23 06:50:16 EDT

I‘m against that I think the platform should stay as lean and small as possible

Comment 4 Andrey Loskutov 2018-05-23 07:33:25 EDT

I'm +-0 (neutral) but only if the default is not to open any popups, because of test stability.

Comment 5 Dani Megert 2018-05-23 08:04:17 EDT

(In reply to Andrey Loskutov from comment #4)
> I'm +-0 (neutral) but only if the default is not to open any popups, because
> of test stability.

Currently it does open the Tips window and I think this is fair. For tests we'd have to pass a property to disable this.

Comment 6 Wim Jongman 2018-05-23 08:09:31 EDT

(In reply to Dani Megert from comment #5)
> (In reply to Andrey Loskutov from comment #4)

Default startup can be set with a property:

https://wiki.eclipse.org/Tip_of_the_Day/Startup_Options

Comment 7 Dani Megert 2018-05-23 08:10:53 EDT

(In reply to Wim Jongman from comment #6)
> (In reply to Dani Megert from comment #5)
> > (In reply to Andrey Loskutov from comment #4)
> 
> Default startup can be set with a property:
> 
> https://wiki.eclipse.org/Tip_of_the_Day/Startup_Options

Yes, but it might be a lot of work for everyone to change their tests and pass that property. If I remember correctly we set a property when running tests. If so, Tips could use that and not show the tips in that case.

Comment 8 Lars Vogel 2018-05-31 10:21:07 EDT

(In reply to Thomas Schindl from comment #3)
> I‘m against that I think the platform should stay as lean and small as
> possible

True for the platform. But the SDK should contain everything we give our users so that we can ensure it works well.

Comment 9 Eclipse Genie 2018-05-31 10:29:56 EDT

New Gerrit change created: https://git.eclipse.org/r/123746

Comment 10 Lars Vogel 2018-06-11 07:53:19 EDT

(In reply to Dani Megert from comment #7)
> (In reply to Wim Jongman from comment #6)
> > (In reply to Dani Megert from comment #5)
> > > (In reply to Andrey Loskutov from comment #4)
> > 
> > Default startup can be set with a property:
> > 
> > https://wiki.eclipse.org/Tip_of_the_Day/Startup_Options
> 
> Yes, but it might be a lot of work for everyone to change their tests and
> pass that property. If I remember correctly we set a property when running
> tests. If so, Tips could use that and not show the tips in that case.

Tips are not shown by default now. Any additional concerns?

Comment 11 Dani Megert 2018-06-18 11:01:58 EDT

(In reply to Lars Vogel from comment #10)
> (In reply to Dani Megert from comment #7)
> > (In reply to Wim Jongman from comment #6)
> > > (In reply to Dani Megert from comment #5)
> > > > (In reply to Andrey Loskutov from comment #4)
> > > 
> > > Default startup can be set with a property:
> > > 
> > > https://wiki.eclipse.org/Tip_of_the_Day/Startup_Options
> > 
> > Yes, but it might be a lot of work for everyone to change their tests and
> > pass that property. If I remember correctly we set a property when running
> > tests. If so, Tips could use that and not show the tips in that case.
> 
> Tips are not shown by default now. Any additional concerns?

Let's wait for the feedback on 4.8 EPPs.

Comment 12 Lars Vogel 2018-08-20 08:04:33 EDT

(In reply to Dani Megert from comment #11)
> Let's wait for the feedback on 4.8 EPPs.

I send an email to EPP to ask for feedback on this bug.

Comment 13 Wim Jongman 2018-08-20 12:06:36 EDT

Created attachment 275456 [details]
Tip Statistics

Comment 14 Wim Jongman 2018-08-20 12:07:33 EDT

I think we currently have Tips in 3 different packages. Given this, the number of uses is quite large. I checked one random tip and it was downloaded 20.000 times across all mirrors since release.

We did not get any user problem reports other than from close contributors. We also did not receive any AERI reports.

Please see the attached PDF.

Comment 15 Lars Vogel 2018-08-23 09:17:53 EDT

(In reply to Wim Jongman from comment #14)
> I think we currently have Tips in 3 different packages. Given this, the
> number of uses is quite large. I checked one random tip and it was
> downloaded 20.000 times across all mirrors since release.
> 
> We did not get any user problem reports other than from close contributors.
> We also did not receive any AERI reports.
> 
> Please see the attached PDF.

Looks like lots of our users are using this. I think this is a good data point to integrate it into the SDK. Dani, WDYT?

Comment 16 Dani Megert 2018-08-23 10:47:42 EDT

(In reply to Lars Vogel from comment #15)
> (In reply to Wim Jongman from comment #14)
> > I think we currently have Tips in 3 different packages. Given this, the
> > number of uses is quite large. I checked one random tip and it was
> > downloaded 20.000 times across all mirrors since release.
> > 
> > We did not get any user problem reports other than from close contributors.
> > We also did not receive any AERI reports.
> > 
> > Please see the attached PDF.
> 
> Looks like lots of our users are using this. I think this is a good data
> point to integrate it into the SDK. Dani, WDYT?

For me it is definitely too late to add such a bug feature for RC1. We can add it early 4.10 so that we have enough time should there be any unexpected issues.

Comment 17 Lars Vogel 2018-09-06 04:35:44 EDT

(In reply to Dani Megert from comment #16)
> For me it is definitely too late to add such a bug feature for RC1. We can
> add it early 4.10 so that we have enough time should there be any unexpected
> issues.

Ok

Comment 18 Eclipse Genie 2018-09-06 07:04:28 EDT

Gerrit change https://git.eclipse.org/r/123746 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=c18b093d3d771e01365bce4f21edf7ccad5bd29e

Comment 19 Lars Vogel 2018-09-06 07:04:35 EDT

Wim, please add to N&N for 4.10.