Description Angelo ZERR 2018-05-19 11:12:18 EDT

Today the compute of size of inlined annotation:

 * width for line content annotation
 * height for line header annotation

are done in the AbstractInlinedAnnotation#draw method. In other words:

 * the first time the draw of inlined annotation draws inside the Styledtext in the wrong place : the content of the inlined annotation overlaps the text of the line. This draw compute the well width/height.
 * once the width/height are computed, the GlyphMetrics style is updated (with StyledText#setStyleRange to take the well place and the annotation is redrawn in the well place.

In windows OS, there is no problem, but in MacOS and sometimes in Linux OS, it can have some trouble like 

 * for Linux https://github.com/angelozerr/jdt-codemining/issues/27
 * for MacOS https://bugs.eclipse.org/bugs/show_bug.cgi?id=532924

To fix this problem, annotation#draw must call only when width/height are computed and GlyphMetrics style is updated. The idea is to provide a new method 

---------------------------------------------------------
Point AbstractInlinedAnnotation#computeSize(GC gc)
---------------------------------------------------------

And for codemining we should have a new API

---------------------------------------------------------
Point ICodeMining#computeSize(GC gc)
---------------------------------------------------------

I know Photon is frozen for the API, but it's a bad design to compute size in the draw of annotation. 

@Mickael I suppose this important issue cannot be done for Photon but for Photon+1 by using some IInlinedAnnotationExtension and ICodeMiningExtension. is that?

@Lars I think this issue will fix your problem  with https://github.com/angelozerr/jdt-codemining/issues/27 but not completely because it seems the problem of overlaps comes from that setStyleRange is not updated, why? I don't know? 

@Martin for MacOS, it will improve the render of inlined annotation but not sure it will fix totally the problem with https://bugs.eclipse.org/bugs/show_bug.cgi?id=532924