Community
Participate
Working Groups
Created attachment 274010 [details] Git mining In JDT CodeMining, while I have implemented "Show recent change" for Git (see attached image), I have noticed that I could write generic classes which could work with: * any SCSM: Git, SVN * any language (Java) by using Revision classes from Platform Text. It should be very cool if Platform Text could provides thoses following codemining classes https://github.com/angelozerr/jdt-codemining/tree/master/org.eclipse.jdt.codemining/src/org/eclipse/jface/text/revisions/provisionnal If you think it's a good idea, I could create a gerrit patch.
As M7 is done, Platform is feature freeze until June. So in any case, no need to rush on this one.
(In reply to Angelo ZERR from comment #0) > Created attachment 274010 [details] > Git mining > > In JDT CodeMining, while I have implemented "Show recent change" for Git > (see attached image), I have noticed that I could write generic classes > which could work with: > > * any SCSM: Git, SVN > * any language (Java) > > by using Revision classes from Platform Text. It should be very cool if > Platform Text could provides thoses following codemining classes > https://github.com/angelozerr/jdt-codemining/tree/master/org.eclipse.jdt.codemining/src/org/eclipse/jface/text/revisions/provisionnal > > > If you think it's a good idea, I could create a gerrit patch. I haven't tried it out, but as long as no dependency to Team is added, it looks OK to me.
> I haven't tried it out, but as long as no dependency to Team is added, it looks OK to me. There is none dependency to Team, but it requires to provide a new extension point to provide an instance of RevsionInformation created by Git, SVN, etc It requires too some utilities class to manage the "ago" time and display the avatar. @Dani, what do you mean with "it looks OK to me" ? You mean that you are OK to add this feature for Photon?
(In reply to Angelo ZERR from comment #3) > > I haven't tried it out, but as long as no dependency to Team is added, it looks OK to me. > > There is none dependency to Team, but it requires to provide a new extension > point to provide an instance of RevsionInformation created by Git, SVN, etc That's find, but make sure it is not added in JFace Text. > @Dani, what do you mean with "it looks OK to me" ? You mean that you are OK > to add this feature for Photon? See target milestone ;-)
(In reply to Angelo ZERR from comment #3) > It requires too some utilities class to manage the "ago" time Why not leave time formatting to the SCM provider? EGit for instance already has different date/time formats, including relative ("ago" time). EGit also has a preference where the user can globally define the format he or she wants to use, and views update when that preference is changed. So there would need to be a way for an EGit code mining provider to request a redraw of its code minings currently being displayed.
> Why not leave time formatting to the SCM provider? EGit for instance already has different date/time formats, including relative ("ago" time). Totally agree with you! For the moment I'm using https://github.com/angelozerr/jdt-codemining/tree/master/org.eclipse.jdt.codemining/src/com/github/marlonlom/utilities/timeago, could you tell me which code of EGit I must call to do that? @Thomas, my work it's just a POC and I'm totally aware to change anything. I think the best idea is that I do a gerrit patch and we change anything. As it is a POC and I have some feedback, my code is not very mature.
(In reply to Angelo ZERR from comment #6) > > Why not leave time formatting to the SCM provider? > could you tell me which code of EGit I must call to do that? org.eclipse.egit.ui.internal.PreferenceBasedDateFormatter is the class that formats date/time values according to the user's preferences as set under Preferences->Team->Git->Date Format.
PreferenceBasedDateFormatter is used to format date, but IMHO I think it should be better to draw "ago time". Do you know where I could find this code which does that?
(In reply to Angelo ZERR from comment #8) > PreferenceBasedDateFormatter is used to format date, but IMHO I think it > should be better to draw "ago time". Do you know where I could find this > code which does that? Well, I think the timestamp should be shown in whatever format the user chooses in the preferences. Not always as an "ago" time. If the user chooses "relative dates", PreferenceBasedDateFormatter uses org.eclipse.jgit.util.GitDateFormatter.RELATIVE, which uses org.eclipse.jgit.util.RelativeDateFormatter.
Thank a lot @Thomas for your helpfull information. Now date is formatted with EGit RelativeDateFormatter https://github.com/angelozerr/jdt-codemining/blob/master/org.eclipse.egit.codemining/src/org/eclipse/egit/codemining/ui/internal/blame/ExtendedBlameRevision.java by implementing my JFace text IRevisionRangeExtension#getFormmatedTime(). For the moment I prefer hard coding that, because for mining "time ago" is better I find that a date pattern : date pattern can be helpfull for other thing, but not for mining. But it's just my opinion. We will see with user feedback.
Angelo, can you please upload a Gerrit for the proposed change. Thomas, as EGit will be main/only consumer of the new API, I hope that you will be available as reviewer.
> Angelo, can you please upload a Gerrit for the proposed change. > Thomas, as EGit will be main/only consumer of the new API, I hope that you will be available as reviewer. @Lars I would like to create a gerrit patch with https:https://github.com/angelozerr/jdt-codemining/tree/master/org.eclipse.jdt.codemining/src/org/eclipse/jface/text/revisions/provisional but I think review will take time because there are a lot of changes. So I would like to be sure that someone like Thomas will have time to review my future gerrit patch. More my current code mining with revision is able to display avatar icon. Do you think Platform Text will be ok to support avatar like I have done https://github.com/angelozerr/jdt-codemining/tree/master/org.eclipse.jdt.codemining/src/org/eclipse/jface/text/revisions/provisional/avatar ? My work with avatar was inspired by https://github.com/eclipse/egit-github/blob/master/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/AvatarStore.java
I think having avatar support in text is fine. As for the other changes I'm sure we will find a reviewer.
> I think having avatar support in text is fine. As for the other changes I'm sure we will find a reviewer. Cool:) Before creating a gerrit patch, we need to fix https://github.com/angelozerr/jdt-codemining/issues/51 If EGit guys can help me to fix this issue, it should be really fantastic. I have spent a lot of time to try to fix it without success -( Any help are welcome!
I think having this in 4.10 is going to be too hard and we should focus the codemining effort of JDT references at the moment to consolidate the integration and start shipping something good using codemining. Other codemining use-cases can target 4.11.
Mass change, please reset target if you still planning to fix this for 4.11.
