Bug 534314 - [code mining] Line numbering and collapse/expand aligned with code lines
Summary: [code mining] Line numbering and collapse/expand aligned with code lines
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 531769
Blocks:
  Show dependency tree
 
Reported: 2018-05-03 08:50 EDT by Angelo ZERR CLA
Modified: 2018-05-03 09:42 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo ZERR CLA 2018-05-03 08:50:54 EDT 
It would be nice to have line numbers and collapse/expand icons aligned with the "real code", so the user can immediately understand where is "real code", and where is "meta-information" looking at the ruler on the left side.

Currently, the line number and the collapse/expand icon are vertically aligned in the middle of the area contanining both code and meta-annotation.

See the problem explained at https://github.com/angelozerr/jdt-codemining/issues/13
Comment 1 Mickael Istria CLA 2018-05-03 08:53:40 EDT 
It's actually a bit hard as there is no clear definition of what is "real code" with the taken approach of glyph metrics. It's again a dep on bug 531769 which is a core missing concept.
Comment 2 Eclipse Genie CLA 2018-05-03 08:54:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/122101
Comment 3 Angelo ZERR CLA 2018-05-03 08:55:17 EDT 
> It's actually a bit hard as there is no clear definition of what is "real code" with the taken approach of glyph metrics.

Please see  https://git.eclipse.org/r/122101
Comment 5 Angelo ZERR CLA 2018-05-03 09:42:45 EDT 
Thank a lot @Mickael!