Bug 533906 - add VarComment highlighting
Summary: add VarComment highlighting
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-21 09:25 EDT by Thierry BLIND CLA
Modified: 2020-05-14 10:17 EDT (History)
2 users (show)

See Also:


Attachments
screenshot (19.98 KB, image/png)
2018-04-21 16:56 EDT, Thierry BLIND CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry BLIND CLA 2018-04-21 09:25:00 EDT
Hi team,
I would like to add specific color highlighting for VarComments:

<?php
/* @var DateTime $date */
$date = null;

Why? Simply to be sure that PDT recognizes it as a VarComment and not as a "normal" multi-line comment (and so easily detect wrongly-written VarComments). It will not do much more (it will not check if "$date" exists), but visually I find it interesting to distinguish phpModuleDeclaration.getVarComments() from other comments ;)

So, what color should I use by default? And what would be the name of the highlighter (for the user)?

Thierry.
Comment 1 Michal Niewrzal CLA 2018-04-21 12:58:24 EDT
Hi Thierry, Im not sure about default color and name. If you could propose somthing, maybe a screenshot, it would be helpful :)
Comment 2 Thierry BLIND CLA 2018-04-21 16:56:13 EDT
Created attachment 273720 [details]
screenshot

Yes of course :)
Look at the new foreground color of comment "/* @var array[DateTime]|DateTime $var */"
For my example I used the same foreground color (and bold font) as for phpdoc @tags and todo task @tags.