Bug 533726 - Allow to detach a view part via the tab menu as in Eclipse 3.x
Summary: Allow to detach a view part via the tab menu as in Eclipse 3.x
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 536239
  Show dependency tree
 
Reported: 2018-04-18 02:34 EDT by Lars Vogel CLA
Modified: 2018-06-25 09:39 EDT (History)
4 users (show)

See Also:


Attachments
menu (5.40 KB, image/png)
2018-04-19 07:20 EDT, Andrey Loskutov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-04-18 02:34:54 EDT
Eclipse 3.x allowed to detach an editor / view via the context menu on the tab. Our of my customer uses this in his 3.x RCP application.

I suggest we also add it back to the tab menu. I think it is relatively useful.
Comment 1 Lars Vogel CLA 2018-04-18 02:36:16 EDT
Dani, Mickael, Andrey, WDYT?
Comment 2 Andrey Loskutov CLA 2018-04-18 02:46:09 EDT
I'm OK. Not that I ever needed this, but if someone wants to implement it - why not?
Comment 3 Mickael Istria CLA 2018-04-18 03:00:02 EDT
I think it'd be useful to get a command (and context-menu, and even maybe even a "Detach current view" in the Window menu) to achieve that. AFAIK, there is no way to do this without drag n drop at the moment, nothing refers to it in shortcuts preference page nor in Ctrl+3. Lack of keyboard-only workflow to perform this action can be perceived as a bug, and your proposal is part of a viable solution.
Comment 4 Eclipse Genie CLA 2018-04-18 04:48:46 EDT
New Gerrit change created: https://git.eclipse.org/r/121312
Comment 5 Mickael Istria CLA 2018-04-18 12:07:51 EDT
Does this new action appear in the Ctrl+3 search?
Comment 6 Lars Vogel CLA 2018-04-18 12:10:40 EDT
(In reply to Mickael Istria from comment #5)
> Does this new action appear in the Ctrl+3 search?

This bug is about the context menu for tabs and a feature loss compared to e3. The new entry behaves as the other menu entries in the tab menu (Close to right, Close, etc). All are not available in Ctrl+3.  

For a new command or a new menu entry please create a new bug. I really like the idea btw.
Comment 7 Mickael Istria CLA 2018-04-18 12:15:08 EDT
(In reply to Lars Vogel from comment #6)
> For a new command or a new menu entry please create a new bug.

Done: bug 533779
Comment 8 Dani Megert CLA 2018-04-18 12:24:35 EDT
(In reply to Andrey Loskutov from comment #2)
> I'm OK. Not that I ever needed this, but if someone wants to implement it -
> why not?

Same here. I never use detached things, but no objection.
Comment 9 Dani Megert CLA 2018-04-18 12:29:46 EDT
I've adjusted the summary to reality. The detach menu item is only available on views in 3.x.

Having said that, I have no issue to also allow this for editors.
Comment 11 Andrey Loskutov CLA 2018-04-19 07:20:16 EDT
Created attachment 273682 [details]
menu

Lars, the way "Detach" menu is added is bad: it is directly next to "Close All", and it is highly likely that people will hit the wrong one.

Please put "Detach" on the top of the menu (so IF someone hits wrong menu, it will be "Close", not "Close All") and please add a separator below.
Comment 12 Lars Vogel CLA 2018-04-19 07:34:57 EDT
(In reply to Andrey Loskutov from comment #11)

> Please put "Detach" on the top of the menu (so IF someone hits wrong menu,
> it will be "Close", not "Close All") and please add a separator below.

Fine for me, I wait a bit with this change to see if Dani has a different opinion here.
Comment 13 Dani Megert CLA 2018-04-19 08:56:28 EDT
(In reply to Lars Vogel from comment #12)
> (In reply to Andrey Loskutov from comment #11)
> 
> > Please put "Detach" on the top of the menu (so IF someone hits wrong menu,
> > it will be "Close", not "Close All") and please add a separator below.
> 
> Fine for me, I wait a bit with this change to see if Dani has a different
> opinion here.

+1 for the proposed changes.
Comment 14 Eclipse Genie CLA 2018-04-19 13:29:24 EDT
New Gerrit change created: https://git.eclipse.org/r/121436
Comment 16 Dani Megert CLA 2018-04-23 08:12:15 EDT
Verified in eclipse-SDK-I20180422-2000-win32-x86_64