Community
Participate
Working Groups
Eclipse Dark Mode -> Go to -> git staging ->click on double click on any file in the staged changes list -> the files will disappear. If you change the focus or Hover yours mouse on the hidden files - they will re-appear. -- Configuration Details -- Product: Eclipse 4.7.3.20180405-1200 (org.eclipse.epp.package.jee.product)Installed Features: org.eclipse.egit 4.9.2.201712150930-r
Created attachment 273597 [details] screenshot for double click on a file in staged changes
Most likely a duplicate of or related to bug 458015, which is a bug in the Eclipse platform, not in EGit.
Comment on attachment 273597 [details] screenshot for double click on a file in staged changes Will Replace.
This is a really annoying bug. I can reproduce it on Windows easily enough: 1. Have more than one unstaged changes, staging view open. 2. Select one file in the unstaged viewer. 3. Select a file in the package explorer -> staging view loses focus, select file in unstaged viewer gets gray (inactive selection) background. 4. Click again on the same file in the unstaged viewer: it gets the blue (active selection) background, but all other files and the viewer's border disappear. The files re-appear when moused over. Happens only on Windows.
Hmm I wana try a fix that i posted in this link https://bugs.eclipse.org/bugs/show_bug.cgi?id=428697#c24 Looking for direction, u got any ?
(In reply to chidveer chinthakuntla from comment #5) > Hmm > I wana try a fix that i posted in this link > https://bugs.eclipse.org/bugs/show_bug.cgi?id=428697#c24 > > Looking for direction, u got any ? Not if you think it's a CSS problem. I don't know that part of Eclipse at all.
*** Bug 540383 has been marked as a duplicate of this bug. ***
*** Bug 540726 has been marked as a duplicate of this bug. ***
New Gerrit change created: https://git.eclipse.org/r/131894
(In reply to Thomas Wolf from comment #4) > This is a really annoying bug. I can reproduce it on Windows easily enough: > > 1. Have more than one unstaged changes, staging view open. > 2. Select one file in the unstaged viewer. > 3. Select a file in the package explorer -> staging view loses focus, select > file in unstaged viewer gets gray (inactive selection) background. > 4. Click again on the same file in the unstaged viewer: it gets the blue > (active selection) background, but all other files and the viewer's border > disappear. The files re-appear when moused over. > > Happens only on Windows. Doesn't work for me, I mean: I don't see the bug at all, neither with the steps above nor with any other work in the Staging view, I have *never* seen this actually on Windows. I'm on 4.10 recent nightly build and up-to-date Windows 10 installation. However, I've switched CSS Themes in Eclipse off long time ago, and I see in the screenshots that they are used. (In reply to Eclipse Genie from comment #9) > New Gerrit change created: https://git.eclipse.org/r/131894 Michael, I assume the patch fixes the problem described above? Or it can be reproduced differently too? @All on CC: which Eclipse / Windows are you running? All have Eclipse "Themes" enabled?
(In reply to Andrey Loskutov from comment #10) > However, I've switched CSS Themes in Eclipse off long time ago Switched it on again and I see this issue! OMG. Just learned another reason to avoid this mess.
(In reply to Andrey Loskutov from comment #11) > (In reply to Andrey Loskutov from comment #10) > > However, I've switched CSS Themes in Eclipse off long time ago > > Switched it on again and I see this issue! OMG. Just learned another reason > to avoid this mess. That points to a either a bug in e4 themeing, or some CSS problem? So we could also try instead of redrawing to call viewer.getControl.reskin(SWT.ALL); Even if the bug gets found and fixed, we'd still have to have some work-around for older Eclipses.
(In reply to Thomas Wolf from comment #12) > (In reply to Andrey Loskutov from comment #11) > > (In reply to Andrey Loskutov from comment #10) > > > However, I've switched CSS Themes in Eclipse off long time ago > > > > Switched it on again and I see this issue! OMG. Just learned another reason > > to avoid this mess. > > That points to a either a bug in e4 themeing, or some CSS problem? I'm totally ignoring all e4 themeing issues as the only solution to fix it is to disable it. It is such an UI overhead on top of the "usual" UI overhead, plus extra bugs.. No, sorry, no idea how deep it is in e4 theming. > Even if the bug gets found and fixed, we'd still have to have some > work-around for older Eclipses. This is true. I wondering however that so far I haven't heard (listening on platform UI) about recent similar issues outside of EGit staging view. And yes, this bug would drive me mad too. So could it be our staging view has a bug, breaking (or pausing) somehow rendering of the tree during "set focus/set selection"?
(In reply to Andrey Loskutov from comment #13) > This is true. I wondering however that so far I haven't heard (listening on > platform UI) about recent similar issues outside of EGit staging view. And > yes, this bug would drive me mad too. So could it be our staging view has a > bug, breaking (or pausing) somehow rendering of the tree during "set > focus/set selection"? Could be, of course. As I wrote in the duplicates, I have tried debugging this several times, but got nowhere. But compare the linked bug in platform: bug 458015, and then 435377 (reporting this very issue back in 2014!), and the supposedly fixed bug 433858.
(In reply to Thomas Wolf from comment #14) > the supposedly fixed bug 433858. Now reading this, for me this is still bug 433858. Just switched back to no-themes and enjoy again flicker free experience.
Gerrit change https://git.eclipse.org/r/131894 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=98fd2ee606047d72e0a9d9263f23bdafcba90e7d
(In reply to Eclipse Genie from comment #16) > Gerrit change https://git.eclipse.org/r/131894 was merged to [master]. > Commit: > http://git.eclipse.org/c/egit/egit.git/commit/?id=98fd2ee606047d72e0a9d9263f23bdafcba90e7d > I still see "empty entries" during DnD to the "Staged Changes" part in the staging view.
(In reply to Lars Vogel from comment #17) > (In reply to Eclipse Genie from comment #16) > > Gerrit change https://git.eclipse.org/r/131894 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/egit/egit.git/commit/?id=98fd2ee606047d72e0a9d9263f23bdafcba90e7d > > > > I still see "empty entries" during DnD to the "Staged Changes" part in the > staging view. @Lars, please see comment 12 to comment 15. Looks like this is some e4 themeing bug. It is highly doubtful we can do much about in EGit.
*** Bug 543970 has been marked as a duplicate of this bug. ***
