Community
Participate
Working Groups
SwtTestUtil#isRunningOnEclipseOrgHudsonGTK should be renamed to SwtTestUtil#isRunningOnEclipseOrgContinousIntegration. Using hudson in the name does not make sense after the migration to Jenkins. Also I assume Jenkins uses a different user name than "hudsonbuild".
Leo, can you take this one as the check is from you?
New Gerrit change created: https://git.eclipse.org/r/120269
Fixed via: https://git.eclipse.org/r/#/c/120732/
"Org" I guess this should be "Or"
(In reply to Dani Megert from comment #4) > "Org" > > I guess this should be "Or" Which Org are you refering to, the one in this name? isRunningOnEclipseOrgContinousIntegration You sure? I think the "Org" is referring to eclipse.org rather than Eclipse 'Or' Continuous integration. I.e, Eclipse.Org 'is' the continuous integration. But I'm not sure. @Lars, wdyt?
(In reply to Leo Ufimtsev from comment #5) > (In reply to Dani Megert from comment #4) > > "Org" > > > > I guess this should be "Or" > > Which Org are you refering to, the one in this name? > isRunningOnEclipseOrgContinousIntegration > > You sure? > > I think the "Org" is referring to eclipse.org rather than Eclipse 'Or' > Continuous integration. Probably, but rather fishy. The code checks for the user being "genie.platform". This can also be on some other random companies server.
(In reply to Dani Megert from comment #6) > > isRunningOnEclipseOrgContinousIntegration > Probably, but rather fishy. The code checks for the user being > "genie.platform". This can also be on some other random companies server. That's a good point. I don't know how to tell if something runs on our Jenkins instance. Is there a better way than using 'genie.platform'? We could rename it to just simply: isRunningOnContinousIntegration wdyt?
(In reply to Leo Ufimtsev from comment #7) > We could rename it to just simply: > isRunningOnContinousIntegration > > wdyt? I think that's fine, plus change the Javadoc to /** Useful if you want some tests not to run on Jenkins with user "genie.platform" */
New Gerrit change created: https://git.eclipse.org/r/120785
Gerrit change https://git.eclipse.org/r/120785 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=1462f91af5e84d5f520979d0b4b9b048f3f3841b
Done, thank you for suggestion.
(In reply to Dani Megert from comment #6) > (In reply to Leo Ufimtsev from comment #5) > > (In reply to Dani Megert from comment #4) > > > "Org" > > > > > > I guess this should be "Or" > > > > Which Org are you refering to, the one in this name? > > isRunningOnEclipseOrgContinousIntegration > > > > You sure? > > > > I think the "Org" is referring to eclipse.org rather than Eclipse 'Or' > > Continuous integration. > > Probably, but rather fishy. The code checks for the user being > "genie.platform". This can also be on some other random companies server. The code checks for username as "genie.platform" which will never satisfy in the current configuration as we moved the linux test jobs to releng hipp(username: platform.releng). Please note We don't have any test jobs on platform hipp now. This freed up executors for platform gerrit jobs.
(In reply to Sravan Kumar Lakkimsetti from comment #12) > (In reply to Dani Megert from comment #6) > > (In reply to Leo Ufimtsev from comment #5) > > > (In reply to Dani Megert from comment #4) > > > > "Org" > > > > > > > > I guess this should be "Or" > > > > > > Which Org are you refering to, the one in this name? > > > isRunningOnEclipseOrgContinousIntegration > > > > > > You sure? > > > > > > I think the "Org" is referring to eclipse.org rather than Eclipse 'Or' > > > Continuous integration. > > > > Probably, but rather fishy. The code checks for the user being > > "genie.platform". This can also be on some other random companies server. > > The code checks for username as "genie.platform" which will never satisfy in > the current configuration as we moved the linux test jobs to releng > hipp(username: platform.releng). > > Please note We don't have any test jobs on platform hipp now. This freed up > executors for platform gerrit jobs. Would checking for user 'platform.releng' determine that we're running tests on the eclipse foundation? Is there any other way that doesn't depend on user name?
