Community
Participate
Working Groups
Now that I'm a full time dark theme user, I find it super annoying that I have to switch to the dark theme every time I open a new workspace with the same Eclipse. I suggest to persist the dark theme in the configuration area and use if for a workspace, unless the workspace has a different preference setting.
Why should we so so for theme but not for any other preference? You can either use Oomph or plugin customization argument.
(In reply to Andrey Loskutov from comment #1) > Why should we so so for theme but not for any other preference? You can > either use Oomph or plugin customization argument. IMHO the theming selection is really a general user thing and re-using would help users. So the proposal is to re-use the user preference unless he has a specific workspace setting. A more general solution for new workspace is handled by Bug 511548.
(In reply to Lars Vogel from comment #2) > A more general solution for new workspace is > handled by Bug 511548. Wouldn't it them make sense to drive Bug 511548 instead of providing a very specific fix for this?
(In reply to Andrey Loskutov from comment #1) > Why should we so so for theme but not for any other preference? You can > either use Oomph or plugin customization argument. +100!
Implementing this would allow us to style the workspace selector dialog with the dark theme. It just feels very off to use the dark theme everywhere and then be greeted by a classic/light themed dialog on every startup.
(In reply to Fabian Pfaff from comment #5) > Implementing this would allow us to style the workspace selector dialog with > the dark theme. > It just feels very off to use the dark theme everywhere and then be greeted > by a classic/light themed dialog on every startup. That is true for every preference as already mentioned by Andrey in comment 1.
(In reply to Dani Megert from comment #6) > (In reply to Fabian Pfaff from comment #5) > > Implementing this would allow us to style the workspace selector dialog with > > the dark theme. > > It just feels very off to use the dark theme everywhere and then be greeted > > by a classic/light themed dialog on every startup. > > That is true for every preference as already mentioned by Andrey in comment > 1. I'm not aware of a preference which should affect the workspace selection dialog. But a dark theme user wants this selection dialog to be styled.
(In reply to Lars Vogel from comment #7) > (In reply to Dani Megert from comment #6) > > (In reply to Fabian Pfaff from comment #5) > > > Implementing this would allow us to style the workspace selector dialog with > > > the dark theme. > > > It just feels very off to use the dark theme everywhere and then be greeted > > > by a classic/light themed dialog on every startup. > > > > That is true for every preference as already mentioned by Andrey in comment > > 1. > > I'm not aware of a preference which should affect the workspace selection > dialog. But a dark theme user wants this selection dialog to be styled. What about the default compliance for Java when creating a new Java project in the new workspace? Or any other preference that you've set in your previous workspace? Adding special handling for the theme is just plain wrong.
We should allow users to have also the ws selection dialog in dark style. I'm ok with Dani's concern that we should not use this setting for new workspaces but if the user used the dark theme in his last ws we should also adjust the first dialog to this theme.
(In reply to Lars Vogel from comment #9) > We should allow users to have also the ws selection dialog in dark style. > > I'm ok with Dani's concern that we should not use this setting for new > workspaces but if the user used the dark theme in his last ws we should also > adjust the first dialog to this theme. This is not a new argument. Again, the same can be said for any other preference like whether you want to see the heap status in the status line. Please don't reopen again. A better solution is to somehow give users the possibility to share their preferences among workspace (not sure if we already have a bug for that). For example allow to export certain preferences to the configuration area. That's something I'd support.
Dani, you seem to fail to understand comment 9. Please read it again and let me know what is unclear. It is not (anymore) about using the setting in a new workspace.
> if the user used the dark theme in his last ws we should also adjust the first > dialog to this theme. So, how would you know what the last workspace was?
(In reply to Dani Megert from comment #12) > > if the user used the dark theme in his last ws we should also adjust the first > dialog to this theme. > > So, how would you know what the last workspace was? Please open a new bug report if you see a solution that is not along the lines of the provided summary.
> Persist last theme in the JFace preference configuration area and re-use for ws selection dialog That does not make sense. Let's assume I have workspaces with "light" and "dark". Why should I get/want the workspace selection dialog in "dark", then choose a workspace with "light" and be in the light theme? This is just wrong.
Thought about this again. Let's try it. (In reply to Dani Megert from comment #12) > > if the user used the dark theme in his last ws we should also adjust the first > dialog to this theme. > > So, how would you know what the last workspace was? The dialog has the workspaces in LRU order and the last one used is selected by default in the dropdown. NOTE: That workspace might not exist anymore, hence we need to fallback to the default theme in that case. (In reply to Dani Megert from comment #14) > Let's assume I have workspaces with "light" and "dark". Why should I > get/want the workspace selection dialog in "dark", then choose a workspace > with "light" and be in the light theme? We could (re-)theme the dialog whenever the user selects another workspace in the dropdown.
