Bug 532921 - Unnoticeable occurance marker in dark theme with generic editor
Summary: Unnoticeable occurance marker in dark theme with generic editor
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on: 534540
Blocks:
  Show dependency tree
 
Reported: 2018-03-27 01:34 EDT by Alexander Kurtakov CLA
Modified: 2018-05-10 10:42 EDT (History)
2 users (show)

See Also:

Attachments
Unnoticable markers (8.30 KB, image/png)
2018-03-27 01:34 EDT, Alexander Kurtakov CLA 		no flags Details
Visible markers (5.87 KB, image/png)
2018-03-27 01:46 EDT, Alexander Kurtakov CLA 		no flags Details
Snap (44.20 KB, image/jpeg)
2018-05-09 12:46 EDT, Vikas Chandra CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2018-03-27 01:34:23 EDT 
Created attachment 273307 [details]
Unnoticable markers

As can be seen in the picture it's pretty hard to notice the occurrance marker in the vertical bar when in dark theme due to the color chosen in generic editor.
To be replaced with occurranceIndicatorColor (as used by other editors) for double effect both more visible and more consistent look.
Comment 1 Alexander Kurtakov CLA 2018-03-27 01:41:54 EDT 
Correction, to use the same color as occuranceTextColor is defined by JDT.
Comment 2 Alexander Kurtakov CLA 2018-03-27 01:46:07 EDT 
Created attachment 273308 [details]
Visible markers

Using the same color as JDT occurrences do.
Comment 3 Eclipse Genie CLA 2018-03-27 01:49:39 EDT 
New Gerrit change created: https://git.eclipse.org/r/120224
Comment 4 Lars Vogel CLA 2018-03-27 01:50:40 EDT 
+1, IIRC we enhanced the JDT color last year.
Comment 6 Alexander Kurtakov CLA 2018-03-27 04:07:38 EDT 
N&N is there now.
Comment 7 Vikas Chandra CLA 2018-05-09 12:33:39 EDT 
As I am verifying the N&N items, I was trying this with target file in generic editor. For me, I couldn't find a lot of difference between occurrence markers in dark theme in  I20180107-2000 & Build id: I20180507-2205. Is there some steps I am missing?
Comment 8 Vikas Chandra CLA 2018-05-09 12:35:12 EDT 
One reason could be that I launched eclipse in dark theme for the 1st time in my life  :)
Comment 9 Vikas Chandra CLA 2018-05-09 12:46:30 EDT 
Created attachment 273982 [details]
Snap

The text of marker would distinguish which one is the snap from old eclipse and which is for M7.

May be this is windows only issue. It will be good to double-check though.
Comment 10 Alexander Kurtakov CLA 2018-05-10 07:28:03 EDT 
(In reply to Vikas Chandra from comment #9)
> Created attachment 273982 [details]
> Snap
> 
> The text of marker would distinguish which one is the snap from old eclipse
> and which is for M7.
> 
> May be this is windows only issue. It will be good to double-check though.

As you can see on my screenshots the diff is quite visible on linux. It is probably the combination of background color contrasting less with old colors on linux that caused the issue. Anyway as it's not regressing on windows and the occurance color used is the same as the Java editor one I don't see anything else to be done on this one. Unless we have bigger issue and the Java editor occurance color is bad on windows and it has to be changed.
Comment 11 Vikas Chandra CLA 2018-05-10 10:17:15 EDT 
Sounds good.

Lets keep this fixed and open the window's only dark theme issue via a bug.
Comment 12 Vikas Chandra CLA 2018-05-10 10:24:15 EDT 
Opened bug 534540