Description Angelo ZERR 2018-03-22 11:10:34 EDT

IMHO I think all extension points of generic editor (contentAssistProcessors, highlightReconcilers, etc) should support an <enabledWhen> in their extension point (like codemining does for instance).

A usecase is with highlightReconcilers. The default word highlightReconcilers works well but if you install lsp4e, it doesn't work since lsp4e defines a highlightReconcilers for any content type. lsp4e should check if the content type has language server (or better if the language server supports highlight). 

In other words, lsp4e should do that:


---------------------------------------------------------
   <extension
         point="org.eclipse.ui.genericeditor.highlightReconcilers">
      <highlightReconciler
            class="org.eclipse.lsp4e.operations.highlight.HighlightReconciler"
            contentType="org.eclipse.core.runtime.text">
         <enabledWhen>
            <with
                  variable="editorInput">
               <test
                     property="org.eclipse.lsp4e.hasLanguageServer">
               </test>
            </with>
         </enabledWhen>            
      </highlightReconciler>
   </extension>
---------------------------------------------------------

After that, even after installing lsp4e, default word highlight will work with *.txt file for instance (today it doesn't work).