Community
Participate
Working Groups
When I'm using pomless builds I'd like to be able to add a property in the <properties>-Section of the parent pom without creating a pom.xml. For one or just a few properties it's simpler to add them to build.properties. I guess TychoModelReader can read build.properties while creating the Model in the read() method.
(In reply to Veselin Markov from comment #0) > When I'm using pomless builds I'd like to be able to add a property in the > <properties>-Section of the parent pom without creating a pom.xml. in tycho-pomless parent poms are always pom.xml so this won't work.
I know there is a parent POM. What I mean is configure bundle or feature build without a pom by changing build.properties.
Is there a decision on this request? It has been a while now since the last activity on this request.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=550239 I think this could be made possible without much effort. @Mickael Istria what do you think? I can provide a patch for that if you think this is fine.
I like this idea a lot, especually when coupled with pom-less. A patch would be welcome.
Will provide a patch once https://git.eclipse.org/r/#/c/148033/ is merged, because of the larger refactorings an intermediate fix would only cause merge headache.
(In reply to Christoph Laeubrich from comment #6) > Will provide a patch once https://git.eclipse.org/r/#/c/148033/ is merged, > because of the larger refactorings an intermediate fix would only cause > merge headache. The linked Gerrit patch is for tycho-extras repo; a fix to inject build.properties for unset properties in the project would better be placed in Tycho core. It seems like Tycho could just add an execution of http://www.mojohaus.org/properties-maven-plugin/read-project-properties-mojo.html in the defined lifecycles.
(In reply to Mickael Istria from comment #7) > The linked Gerrit patch is for tycho-extras repo; I just thought that from the original request (In reply to Veselin Markov from comment #0) > When I'm using pomless builds I'd like to be able to add a property in the this especially was for pomless-build since with a clasical pom.xml I can add properties directly to the pom or use the proeprties plugin (without any help of tycho) or do I misunderstand the issue?
(In reply to Christoph Laeubrich from comment #8) > this especially was for pomless-build since with a clasical pom.xml I can > add properties directly to the pom or use the proeprties plugin (without any > help of tycho) or do I misunderstand the issue? This enhancement could have value also foe projects that have a pom, and don't really require pom-less to be implemented IMO, so if we can have a more generic and useful solution than making it pomless-only,we should take adcantage of it.
So tycho (what module?) should somehow include the properties maven module and use build.properties as default? Don't know how much work would that be to implement in generic tycho :-\
@Mickael I'm curious if you think we should still implement this? As with the takairi update this is now possible for pomless builds and if a pom.xml is present why not add the properties there? Anyways if you think this is still useful I can try to prepare a patch for this.
(In reply to Christoph Laeubrich from comment #11) > @Mickael I'm curious if you think we should still implement this? To me (and my use cases), this isn't something necessary. So I won't personally invest time on it, beyond reviews for the sake of a healthy community. However, I think such feature would make sense for Tycho, there doesn't seem technical nor strategical reason to reject such change. If you have need for it, then feel free to implement it; but if you don't, then don't feel obliged and feel free to dedicate your time and attention to something else that's more profitable to you. No-one could fairly rant about your own agenda and I don't believe it would cause trouble for Tycho's future ;) > Anyways if you think this is still useful I can try to prepare a patch for > this. If you really want to do it, just do it ;)
New Gerrit change created: https://git.eclipse.org/r/c/tycho/org.eclipse.tycho/+/165973
Gerrit change https://git.eclipse.org/r/c/tycho/org.eclipse.tycho/+/165973 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=a08e80d9a95ef6ac7132f2da5d8edbdeb449819c
Please add a note about it in the release notes.
done
