Bug 532326 - [code mining] Fix redraw of character with custom font style
Summary: [code mining] Fix redraw of character with custom font style
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Angelo ZERR CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 532359
  Show dependency tree
 
Reported: 2018-03-12 09:28 EDT by Angelo ZERR CLA
Modified: 2018-04-05 17:28 EDT (History)
1 user (show)

See Also:

Attachments
Redraw character font style (7.82 KB, image/png)
2018-03-12 09:33 EDT, Angelo ZERR CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo ZERR CLA 2018-03-12 09:28:33 EDT 
As https://bugs.eclipse.org/bugs/show_bug.cgi?id=531719 was wontfix, I have managed "Font getFont(int style)" inside InlinedAnnotationSupport.

This private API gives 2 features:

 * fix redraw of character of line content annotation when this character as a custom font style (bold, italic, bold & italic both)
 * set line header codemining in italic. I think it's a good choice because in JDT Java Editor, mining and Java annotation (ex: "@Override") are renderer with same style. For the moment it's hard coded, but in the future mining renderer should be customized with preferences "Colors and Fonts".
Comment 1 Eclipse Genie CLA 2018-03-12 09:30:39 EDT 
New Gerrit change created: https://git.eclipse.org/r/119232
Comment 2 Angelo ZERR CLA 2018-03-12 09:33:48 EDT 
Created attachment 273084 [details]
Redraw character font style

Here a screenshot before the fix (the 'n' of 'null' is not bolded) and after the fix (the 'n' of 'null' is bolded).
Comment 3 Mickael Istria CLA 2018-03-12 12:43:31 EDT 
Please split this bug into 2 different ones since one is about fixing a bug and the other in an enhancement; and fixes affect different classes.
Comment 4 Angelo ZERR CLA 2018-03-12 12:51:35 EDT 
> Please split this bug into 2 different ones

Ok I have renamed the issue. Please see my new gerrit patch.
Comment 6 Eclipse Genie CLA 2018-03-12 15:38:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/119267