Bug 531882 (Snippet230_tableCol_icon_packing) - [Gtk3] Snippet230, tablecolumn icons on right size get cut off
Summary: [Gtk3] Snippet230, tablecolumn icons on right size get cut off
Status: VERIFIED FIXED
Alias: Snippet230_tableCol_icon_packing
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.9 M2   Edit
Assignee: Xi Yan CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
: 301887 (view as bug list)
Depends on:
Blocks: FixSwtSnippetsOnGtk3
  Show dependency tree
 
Reported: 2018-03-01 16:12 EST by Leo Ufimtsev CLA
Modified: 2021-05-17 05:23 EDT (History)
2 users (show)

See Also:

Attachments
Gtk2, icons on right snow for all columns. (OK) (19.13 KB, image/png)
2018-03-01 16:14 EST, Leo Ufimtsev CLA 		no flags Details
Gtk3, icons on right for col1 and col2 are cut off. Shown when you expand them. (18.50 KB, image/png)
2018-03-01 16:14 EST, Leo Ufimtsev CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Ufimtsev CLA 2018-03-01 16:12:42 EST 
With snippet230, on Gtk3 icons on the right side of column 1 & 2 are cut off.
On Gtk2, they show as expected.

Maybe on gtk3 the client area doesn't take these icons properly into consideration.

See screenshots.
Comment 1 Leo Ufimtsev CLA 2018-03-01 16:14:01 EST 
Created attachment 272965 [details]
Gtk2, icons on right snow for all columns. (OK)
Comment 2 Leo Ufimtsev CLA 2018-03-01 16:14:27 EST 
Created attachment 272966 [details]
Gtk3, icons on right for col1 and col2 are cut off. Shown when you expand them.
Comment 3 Eric Williams CLA 2018-07-03 16:33:16 EDT 
Xi, this might be similar to the TableColumn.pack() fix you did awhile ago. Please investigate.
Comment 4 Eclipse Genie CLA 2018-07-04 16:50:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/125561
Comment 6 Eric Williams CLA 2018-07-10 10:33:43 EDT 
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/125561 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=90b11d0439eaf39696ee5c80da07e42a77c9ce34

Patch is in master, thanks Xi.
Comment 7 Eric Williams CLA 2018-08-23 12:21:29 EDT 
*** Bug 301887 has been marked as a duplicate of this bug. ***