Bug 531747 - Rename "Build Order" pref page to "Build"
Summary: Rename "Build Order" pref page to "Build"
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, usability
Depends on:
Blocks:
 
Reported: 2018-02-27 12:10 EST by Mickael Istria CLA
Modified: 2018-04-24 09:58 EDT (History)
3 users (show)

See Also:

Attachments
Proposed page (70.11 KB, image/png)
2018-04-17 11:56 EDT, Mickael Istria CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2018-02-27 12:10:16 EST 
In order to factorize most workspace options related to workspace build, I suggest we rename the "Build Order" preference page to "Build", keep is under "Workspace" and move current and future options related to workspace build (such as "build automatically" or "max simultaneous builds" to this page).
Comment 1 Mickael Istria CLA 2018-02-27 12:10:46 EST 
@Dani: what do you think about this proposal?
Comment 2 Alexander Kurtakov CLA 2018-04-17 08:14:03 EDT 
+1. It would make it more clear as build automatically and max simultaneous builds are hard to find in the too crowded workspace page.
Comment 3 Dani Megert CLA 2018-04-17 08:36:28 EDT 
(In reply to Alexander Kurtakov from comment #2)
> +1. It would make it more clear as build automatically and max simultaneous
> builds are hard to find in the too crowded workspace page.

+1.
Comment 4 Eclipse Genie CLA 2018-04-17 09:35:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/121258
Comment 5 Eclipse Genie CLA 2018-04-17 10:42:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/121267
Comment 8 Mickael Istria CLA 2018-04-17 10:59:53 EDT 
Commits about renaming the page were merged.
2 further commits are coming (one for UI and one for doc) about moving the build related settings. I've separated them because updating the doc for this change is much more work than just rename, so going incrementally seemed easier to me.
Comment 9 Eclipse Genie CLA 2018-04-17 11:02:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/121270
Comment 10 Mickael Istria CLA 2018-04-17 11:56:10 EDT 
Created attachment 273650 [details]
Proposed page

This screenshot is a proposal of how the Build pref page would look like after moving build-related prefs from Workspace to Build.
Comment 11 Alexander Kurtakov CLA 2018-04-17 12:03:00 EDT 
I like it.
Comment 12 Dani Megert CLA 2018-04-19 12:02:37 EDT 
(In reply to Alexander Kurtakov from comment #11)
> I like it.

Same here.

NOTE: When moving the preferences you need to
- make sure to update the keywords for search
- update the documentation (especially screenshots)
Comment 13 Mickael Istria CLA 2018-04-20 08:57:45 EDT 
(In reply to Dani Megert from comment #12)
> - make sure to update the keywords for search

Here are the current keywords

     <page
            category="org.eclipse.ui.preferencePages.Workbench"
            class="org.eclipse.ui.internal.ide.dialogs.IDEWorkspacePreferencePage"
            id="org.eclipse.ui.preferencePages.Workspace"
            name="%PreferencePages.Workspace">
         <keywordReference id="org.eclipse.ui.ide.workspace"/>
         <keywordReference id="org.eclipse.ui.ide.encoding"/>
         <keywordReference id="org.eclipse.ui.ide.project"/>
         <keywordReference
               id="org.eclipse.ui.ide.nature">
         </keywordReference>
      </page>
      <page
            category="org.eclipse.ui.preferencePages.Workspace"
            name="%PreferencePages.BuildOrder"
            class="org.eclipse.ui.internal.ide.dialogs.BuildOrderPreferencePage"
            id="org.eclipse.ui.preferencePages.BuildOrder">
      </page>

So it seems like there is no need to change them. Do you have some specific suggestion?

> - update the documentation (especially screenshots)

Yes... if there weren't this requirement, I'd have merged the patch 3 days ago already ;)
Comment 14 Mickael Istria CLA 2018-04-20 09:14:05 EDT 
@Dani: by the way, IIRC, there are some guidelines for screenshot. If so, can you please remind me where I can find them?
Comment 15 Dani Megert CLA 2018-04-20 09:23:45 EDT 
(In reply to Mickael Istria from comment #13)
> So it seems like there is no need to change them. Do you have some specific
> suggestion?

I did not verify any change. Will see when it is merged.


(In reply to Mickael Istria from comment #14)
> @Dani: by the way, IIRC, there are some guidelines for screenshot. If so,
> can you please remind me where I can find them?

You can use http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/tree/instructions.html
Comment 17 Mickael Istria CLA 2018-04-20 15:19:50 EDT 
Patch merged and doc updated (with other stuff that were out of date)
Comment 18 Dani Megert CLA 2018-04-23 08:18:04 EDT 
(In reply to Dani Megert from comment #15)
> (In reply to Mickael Istria from comment #13)
> > So it seems like there is no need to change them. Do you have some specific
> > suggestion?
> 
> I did not verify any change. Will see when it is merged.

The very first keywords I tested is no longer work, e.g. "save" or "automatically".

As said, you have to find out which keywords were added for the 'Workspace' page to find the preferences that you moved. Those need to be moved too.
Comment 19 Eclipse Genie CLA 2018-04-23 08:47:12 EDT 
New Gerrit change created: https://git.eclipse.org/r/121568
Comment 21 Dani Megert CLA 2018-04-24 09:58:30 EDT 
Verified in eclipse-SDK-I20180423-2000-win32-x86_64.