531746 – Editor search dropdown should automatically support wildcards

Bug 531746 - Editor search dropdown should automatically support wildcards

Summary: Editor search dropdown should automatically support wildcards

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.7.1
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.8 M6
Assignee:	Patrik Suzzi
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-02-27 12:01 EST by Lars Vogel
Modified:	2022-04-03 06:10 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit 549379 543191

Attachments
Screenshot of the editor dropdown (26.27 KB, image/png) 2018-02-27 12:02 EST, Lars Vogel	no flags	Details
desired behavior (92.84 KB, image/png) 2018-03-01 23:30 EST, Patrik Suzzi	no flags	Details
Wildcard is now added automatically (10.93 KB, image/png) 2018-03-02 00:36 EST, Patrik Suzzi	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2018-02-27 12:01:06 EST

Comment 1 Lars Vogel

2018-02-27 12:02:49 EST

Created attachment 272916 [details]
Screenshot of the editor dropdown

Comment 2 Lars Vogel

2018-02-27 12:03:34 EST

Patrik, something for you? IIRC you worked on the editor drop-down list before.

Comment 3 Patrik Suzzi

2018-03-01 23:24:48 EST

IIUC, when you press CTRL+E (open the editor selection dialog) and type "L", you want to filter the entries like you typed "*L".

Comment 4 Patrik Suzzi

2018-03-01 23:30:41 EST

Created attachment 272968 [details]
desired behavior

Comment 5 Eclipse Genie

2018-03-02 00:34:25 EST

New Gerrit change created: https://git.eclipse.org/r/118488

Comment 6 Patrik Suzzi

2018-03-02 00:36:03 EST

Created attachment 272969 [details]
Wildcard is now added automatically

Comment 7 Lars Vogel

2018-03-02 03:16:01 EST

(In reply to Patrik Suzzi from comment #4)
> Created attachment 272968 [details]
> desired behavior

+1

Comment 8 Till Brychcy

2018-03-02 03:38:23 EST

What if I have editors open that start with "H"? 
Will they still be first, before all "substring" matches?

Comment 9 Lars Vogel

2018-03-02 04:23:33 EST

(In reply to Till Brychcy from comment #8)
> What if I have editors open that start with "H"? 
> Will they still be first, before all "substring" matches?

IIRC you could use the ^ regex to match the first character. This would also be consistent with the handling in PDE.

Comment 10 Eclipse Genie

2018-03-02 13:54:37 EST

Gerrit change https://git.eclipse.org/r/118488 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0d488d972172591b2e0d594602799548e5a1719a

Comment 11 Lars Vogel

2018-03-02 13:55:11 EST

Thanks Patrick, please also add to n&n.

Comment 12 Lars Vogel

2018-03-02 13:57:31 EST

Till, can you open a bug so that we list prefix matches before other matches?

Comment 13 Till Brychcy

2018-03-02 15:32:28 EST

Hmmm why release this already without really thinking about it?
Is this kind of change not allowed after M6?

Comment 14 Lars Vogel

2018-03-02 16:29:31 EST

(In reply to Till Brychcy from comment #13)
> Hmmm why release this already without really thinking about it?
> Is this kind of change not allowed after M6?

M7 is polish, so we are good.

Comment 15 Petr Bodnar

2022-04-03 06:10:46 EDT

For the record, this one was reverted due to braking some related functionality - see 552144.

Also, there is de-facto the same feature request in 531785 (created just 1 day after this one) which covers the Open Resource and possibly also the Open Type dialogs - all these are pretty similar in the searching features.