Community
Participate
Working Groups
Created attachment 272844 [details] Screenshot The Combobox looks not good with a dark background. See screenshot from the dark theme. Eclipse SDK Version: Photon (4.8) Build id: I20180220-2000 OS: Linux, v.4.13.0-32-generic, x86_64 / gtk 3.22.25, WebKit 2.18.6
The issue is specific to Ambiance theme. Doesn't occur on Adwaita. The reason for above behavior is that Adwaita has a dark-variant where as Ambiance doesn't. In Eclipse, we request OS help by asking for the 'dark' version of a theme, but in the case of Ambiance there is no dark version to request. OS.java: public static final void setDarkThemePreferred(boolean preferred){ .. g_object_set(GTK.gtk_settings_get_default(), GTK.gtk_application_prefer_dark_theme, preferred, 0); g_object_notify(GTK.gtk_settings_get_default(),GTK.gtk_application_prefer_dark_theme); } Thoughts that come to mind: - Maybe see if we can update combobox to do more css theming in the case of setBackgroud(), something like this: https://git.eclipse.org/r/#/c/45077/6/bundles/org.eclipse.swt/Eclipse+SWT/gtk/org/eclipse/swt/widgets/Button.java - I recall working on this when I was an intern, can't remember the outcome very well. Background color logic has changed quite a bit since thou: https://git.eclipse.org/r/#/c/45415/ - Consider using alternative system theme that has a dark-variant if dark theme is desired.
Lars, do you still face this one?
(In reply to Alexander Kurtakov from comment #2) > Lars, do you still face this one? Nope
Not sure why this one was under 4.10 M3, marking as WORKSFORME.
