Bug 531296 - [code mining] Text annotation markers add support of inline annotations
Summary: [code mining] Text annotation markers add support of inline annotations
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-16 15:29 EST by Roman Parashchyn CLA
Modified: 2019-03-22 12:58 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Parashchyn CLA 2018-02-16 15:29:18 EST
https://bugs.eclipse.org/bugs/show_bug.cgi?id=529011  Has feature request to add inline annotations for function parameters.

It would be great to add ability to create inline annotation via markers. so you can just create a marker and set additional attributes that will make it either header or inline and provide text to be shown as marker already has most of the required attributes.


This will improve inline markers usage as no extra reconcilers will be required
.
Comment 1 Mickael Istria CLA 2018-02-16 15:35:39 EST
Note that markers are associated to a file, are not specific to an editor, and do trigger events when created. So if you want to go towards usage of markers, it means that the annotation would be visible and all editors that have support for code mining.
What additional value do you think markers would bring to the CodeMining API which a focused CodeMining provider wouldn't?
Comment 2 Roman Parashchyn CLA 2018-02-16 15:41:46 EST
I'm thinking of simplifying creation of text annotations creation.  
Agree that it will be visible to all editors. But this can bring support of new marker types where plugin developer can add marker with some help inline.

Or even writing generic plugins not related to editor that will provide small features like color samples in https://www.eclipse.org/eclipse/news/4.8/M5/#codemining-extension-point.
Comment 3 Mickael Istria CLA 2018-02-16 15:45:34 EST
(In reply to Roman Parashchyn from comment #2)
> I'm thinking of simplifying creation of text annotations creation.

Have you tried the API? So far, I don't have the impression it does require much simplification. What use-case did you try that you think would be easier with markers?

> Or even writing generic plugins not related to editor that will provide
> small features like color samples in
> https://www.eclipse.org/eclipse/news/4.8/M5/#codemining-extension-point.

Note that this color preview in the example here is NOT a code mining per se, but a TextAnnotation which involves a specific drawing strategy. A marker couldn't easily provide such a specific drawing strategy.
Comment 4 Mickael Istria CLA 2018-12-03 11:35:16 EST
Isn't it a dup of bug 540443 ?
Comment 5 Mickael Istria CLA 2019-03-15 05:44:19 EDT
While the overall idea is interesting, bug 540443 shows that similar things are already achievable with little code (hence introducing new API may not be worth the cost) and there is no concrete user-story supporting it at the moment.
Reducing priority.