Community
Participate
Working Groups
Created attachment 272698 [details] Light icon before the change
Created attachment 272699 [details] Light icon after the change
Created attachment 272700 [details] Dark icon before the change
Created attachment 272701 [details] Dark icon after the change
New Gerrit change created: https://git.eclipse.org/r/117514
New Gerrit change created: https://git.eclipse.org/r/117515
Matthias, what do you think? I personally think we should also remove the "yellowish" border around the icon.
(In reply to Lars Vogel from comment #7) > Matthias, what do you think? I personally think we should also remove the > "yellowish" border around the icon. Gerrit change for text adjusted with the removed border, so that Matthias can test this easier.
(In reply to Lars Vogel from comment #4) > Created attachment 272701 [details] > Dark icon after the change Mh. I am not so sure about that change. Do you think the white background on that piece of paper is really to light? Look at the "block selection" icon. It also has a white piece of paper on it. In addition I think the contrast of the dark blue P-ish symbol with the dark background is not worse.
(In reply to Matthias Becker from comment #9) > Mh. I am not so sure about that change. Do you think the white background on > that piece of paper is really to light? Yes, looks horrible to me. I think if we remove it, the light theme still looks good and the dark theme much better. > Look at the "block selection" icon. It also has a white piece of paper on it. > In addition I think the contrast of the dark blue P-ish symbol with the dark > background is not worse. I opened another bug for the block selection icon.
Created attachment 272705 [details] Dark icon without white background and border New icon without background and border. Looks awesome to me.
(In reply to Lars Vogel from comment #10) > I opened another bug for the block selection icon. We have a lot of icons with a "piece of pager" on it. "Toggle Work Wrap", "Block Selection", "Next / Previ Annotation" / "Java Comiplation Unit editor tab icon" U really want to change all of them? I would really key them as they are. Maybe we add some transparency to the white piece of paper. Via this the dark background can shine through. On the light theme the pager would be light. On the dark theme it would be darker (but still visible as such).
Yes, I think we should change all of them (at least the ones visible in the main toolbar). Transparency might also work, but removing the background completely works really good to me. I try to change all of them to see how this looks. Keep in mind that the "paper" is actually dark in the dark theme, hence the light background is wrong.
(In reply to Lars Vogel from comment #13) > I try to change all of them to see how this looks. Keep in mind that the > "paper" is actually dark in the dark theme, hence the light background is > wrong. Then I rally would go for the transparency because in your current approach the paper is gone completly
Can you upload a patch with transparency? Your graphics skills are way better. I was able to delete the background... :-)
(In reply to Lars Vogel from comment #15) > Can you upload a patch with transparency? Your graphics skills are way > better. I was able to delete the background... :-) No reply, so I assume this is a no. I give it a try....
(In reply to Lars Vogel from comment #16) > (In reply to Lars Vogel from comment #15) > > Can you upload a patch with transparency? Your graphics skills are way > > better. I was able to delete the background... :-) > > No reply, so I assume this is a no. I give it a try.... Transparency looks blury, I think the best solution is to remove the background and for block and whitespace also the border.
Created attachment 272736 [details] Light icon before the change
Created attachment 272737 [details] Light icon after the change
Created attachment 272738 [details] Dark icon before the change
Created attachment 272739 [details] Dark icon after the change
Tony, what do you think?
(In reply to Lars Vogel from comment #16) > (In reply to Lars Vogel from comment #15) > > Can you upload a patch with transparency? Your graphics skills are way > > better. I was able to delete the background... :-) > > No reply, so I assume this is a no. I give it a try.... No this is not a "no". I just did not have time yet to look into this.
(In reply to Lars Vogel from comment #17) > (In reply to Lars Vogel from comment #16) > > (In reply to Lars Vogel from comment #15) > > > Can you upload a patch with transparency? Your graphics skills are way > > > better. I was able to delete the background... :-) > > > > No reply, so I assume this is a no. I give it a try.... > > Transparency looks blury, I think the best solution is to remove the > background and for block and whitespace also the border. I just tried this out once again. You are right. Transparency does look foggy / dirty. So I am ok with removing the background. For the show whitespace icon I am also ok with removing the border. But the block selection mode icon should keep it's border. Without the border this (already suboptimal icon) does not longer transport it's meaning any more.
(In reply to Matthias Becker from comment #24) > So I am ok with removing the background. Great. > But the > block selection mode icon should keep it's border. Without the border this > (already suboptimal icon) does not longer transport it's meaning any more. +1 ----- Can you remind me how I can create the 2x png files?
(In reply to Lars Vogel from comment #25) > (In reply to Matthias Becker from comment #24) > > > So I am ok with removing the background. > > Great. > > > But the > > block selection mode icon should keep it's border. Without the border this > > (already suboptimal icon) does not longer transport it's meaning any more. > > +1 > > ----- > Can you remind me how I can create the 2x png files? do you want to finish this or should I take over?
(In reply to Matthias Becker from comment #26) > > Can you remind me how I can create the 2x png files? > > do you want to finish this or should I take over? I would like to finish this, if this is OK for you. I only need help with generating the 2x png files. mvn org.eclipse.images:org.eclipse.images.renderer:render-icons -Declipse.svg.scale=2 results in an error for me.
it should be mvn org.eclipse.images:org.eclipse.images.renderer:render-icons -Declipse.svg.scale=2 -Declipse.svg.createFragments=false
*** Bug 531271 has been marked as a duplicate of this bug. ***
Gerrit change https://git.eclipse.org/r/117514 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=64e89a8bde646e80ac219573267de2aaef01aa85
Gerrit change https://git.eclipse.org/r/117515 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=34e5c675c0c3f4b78104f08bf014203b02f14842
New Gerrit change created: https://git.eclipse.org/r/117811
Gerrit change https://git.eclipse.org/r/117811 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=b6f0f9bd2164261461b4cfe642d1709c02b7dd0e
New Gerrit change created: https://git.eclipse.org/r/117842
Gerrit change https://git.eclipse.org/r/117842 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=84ce4aa4a4cf78c774c6772a9dd86bb1ef8e9f11
New Gerrit change created: https://git.eclipse.org/r/143258
Gerrit change https://git.eclipse.org/r/143258 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=56e0b049337d859eb604f716f65658b154f60f20
