Community
Participate
Working Groups
Created attachment 272662 [details] Background If I open an image in the Eclipse browser in the dark theme, the remaining background is white. Not sure if this can be changed, but if, we should change the default background to dark in the dark theme.
Adding Matthias, as he is interested in improving the dark theme.
anyway if us open up a webpage in the browser that has a bright background this won't change due to the dark theme.
(In reply to Matthias Becker from comment #2) > anyway if us open up a webpage in the browser that has a bright background > this won't change due to the dark theme. True, this bug is for the empty space default.
There is already: .MPart Table, .MPart Browser, .Mpart OleFrame, .MPart ViewForm, .MPart ViewForm > ToolBar, .MPart ViewForm > CLabel, .MPart PageBook > Label, .MPart PageBook > SashForm, #org-eclipse-help-ui-HelpView LayoutComposite > LayoutComposite, #org-eclipse-help-ui-HelpView LayoutComposite > LayoutComposite > * { background-color: #313538; color: #CCC; } in /org.eclipse.ui.themes/css/dark/e4-dark_partstyle.css the setBackground method is called for the browser widget but (at least on macOS) this does not seem to have any effect. On Linux this also seems to have no effect (as Lars is on Linux). I don't know how it is on Windows. SWT Team: Can you have a look at this?
Looks to me that the SWT Browser widgets ignores the setBackground call. SWT team is this a known issue? Would be nice to have this? Otherwise every empty browser will look bad in the dark theme. import org.eclipse.swt.*; import org.eclipse.swt.browser.*; import org.eclipse.swt.layout.*; import org.eclipse.swt.widgets.*; public class Snippet128 { public static void main(String [] args) { Display display = new Display(); final Shell shell = new Shell(display); FillLayout fillLayout = new FillLayout(); shell.setLayout(fillLayout); final Browser browser= new Browser(shell, SWT.NONE); browser.setBackground(Display.getDefault().getSystemColor(SWT.COLOR_CYAN)); shell.open(); while (!shell.isDisposed()) { if (!display.readAndDispatch()) display.sleep(); } display.dispose(); } }
Yea, at the moment it's ignored. The background in browser widget is HTML based. So setText() with custom html background would make the widget black. Or call execute() with javascript that makes background black. To implement native support, we'd have to cache the setBackground() and re-apply it via javascript after every page load. The implementation would have to tranlsate the COLOR in setBackground(COLOR) into html and do something like ~document.body.setBackground<..> It can be done, would probably take me a a day or so to implement/test/verify. Does the same problem occur on Win/Cocoa btw?(I haven't tested).
(In reply to Leo Ufimtsev from comment #6) > Does the same problem occur on Win/Cocoa btw?(I haven't tested). On macOS the background also is white
Thanks for testing. One problem might be that if a theme sets the background, then browsing web-pages (e.g google) might not look proper. setForeground() should also be considered in such situations. Also not sure if webkit/I.E browsers can actually render an image with custom background for the non-image area. Would have to experiment. I think at the moment Gtk3 bug fixes may take higher priority than fixing a theme issue. We have enough gtk3 bugs to keep us busy for a while :-) -> adding helpwanted tag. Patches are welcome. A workaround at platform level would be to load html page with it's own background and embed the image in the page.
(In reply to Leo Ufimtsev from comment #6) > Does the same problem occur on Win/Cocoa btw?(I haven't tested). Same problem on Windows.
Nikita, would it be possible on the SWT Windows side to support setBackground for Browser? This would allow making empty browsers look better in the dark theme.
(In reply to Lars Vogel from comment #10) > Nikita, would it be possible on the SWT Windows side to support > setBackground for Browser? This would allow making empty browsers look > better in the dark theme. This could potentially be done at common level, i.e, one implementation for gtk/cocoa/win that executes javascript when setBackground(..) is called.
I'm not sold to the idea of setBackround for browser - it should be the actual content defining the background.
(In reply to Alexander Kurtakov from comment #12) > I'm not sold to the idea of setBackround for browser - it should be the > actual content defining the background. Yes, this would only be useful for an empty browser.
I have even tried with Firefox running in dark theme and the default background (e.g. about: ) is some neutral light gray .
So what we wnat to achieve is similar to https://support.mozilla.org/en-US/questions/1106886 ?
Overriding background for all pages is a total no-go. But overriding for empty page is doable and webkitgtk has API for that webkit_web_view_set_background_color
(In reply to Alexander Kurtakov from comment #16) > Overriding background for all pages is a total no-go. > But overriding for empty page is doable and webkitgtk has API for that > webkit_web_view_set_background_color This is interesting, I never knew about this API when I suggested the above. The api is definitely the better approach.
