Bug 531047 - [Dark Theme] Adjust dark theme with styling for the range indicator preference from Bug 514043
Summary: [Dark Theme] Adjust dark theme with styling for the range indicator preferenc...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M6   Edit
Assignee: Matthias Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on: 514043
Blocks:
  Show dependency tree
 
Reported: 2018-02-12 09:10 EST by Lars Vogel CLA
Modified: 2018-02-13 08:08 EST (History)
1 user (show)

See Also:

Attachments
range indicator in dark theme before change (224.58 KB, image/png)
2018-02-13 05:15 EST, Matthias Becker CLA 		no flags Details
range indicator in dark theme after change (226.19 KB, image/png)
2018-02-13 05:16 EST, Matthias Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-02-12 09:10:25 EST 
Once we fix Bug 514043, we should also adjust the default dark theme in Eclipse.
Comment 1 Lars Vogel CLA 2018-02-12 09:10:50 EST 
Matthias, can you take this one?
Comment 2 Matthias Becker CLA 2018-02-12 09:15:52 EST 
will look into this once the range indicator color is configurable
Comment 3 Matthias Becker CLA 2018-02-13 04:16:06 EST 
should the styling be:
1) added to /org.eclipse.ui.themes/css/dark/e4-dark_preferencestyle.css 
or 
2) added to a new css in org.eclipse.ui.workbench.texteditor
where the color is defined and stored?
Comment 4 Eclipse Genie CLA 2018-02-13 05:15:16 EST 
New Gerrit change created: https://git.eclipse.org/r/117242
Comment 5 Matthias Becker CLA 2018-02-13 05:15:23 EST 
Created attachment 272656 [details]
range indicator in dark theme before change
Comment 6 Matthias Becker CLA 2018-02-13 05:16:31 EST 
Created attachment 272657 [details]
range indicator in dark theme after change

What do you think about the color of the range indicator in the dark theme.
I am open to other proposals. I looked around how VScode or IntelliJ does it. But they don't have colored range-indicator as eclipse has.
Comment 7 Lars Vogel CLA 2018-02-13 05:24:24 EST 
(In reply to Matthias Becker from comment #6)
> Created attachment 272657 [details]
> range indicator in dark theme after change
> 
> What do you think about the color of the range indicator in the dark theme.
> I am open to other proposals. I looked around how VScode or IntelliJ does
> it. But they don't have colored range-indicator as eclipse has.

+1 looks awesome to me.
Comment 8 Eclipse Genie CLA 2018-02-13 07:39:59 EST 
New Gerrit change created: https://git.eclipse.org/r/117253
Comment 10 Eclipse Genie CLA 2018-02-13 08:08:10 EST 
Gerrit change https://git.eclipse.org/r/117253 was merged to [master].
Commit: http://git.eclipse.org/c/www.git/commit/?id=88473563e91e94c1692ca9eb721f780fc877b7b8