Community
Participate
Working Groups
Created attachment 272552 [details] Screenshot As a long term goal, I would like to change the Find/Relace dialog to be inline, e.g., not blocking. To make it already a bit better (less blocking), I suggest to make it wider and put all buttons (except close) into one row. To open the dialog press Ctrl+F in a text editor.
Jonas, can you give it a try? IIRC Repo is eclipse.platform.text
New Gerrit change created: https://git.eclipse.org/r/117889
(In reply to Lars Vogel from comment #0) > Created attachment 272552 [details] > Screenshot > > As a long term goal, I would like to change the Find/Relace dialog to be > inline, e.g., not blocking. What do you mean by "blocking"? Making it wider even hides more stuff from the underlying editor, so, not sure why that should be better.
Created attachment 272799 [details] Old Button position
Created attachment 272800 [details] New buttons
Thanks Jonas, to me it looks better and by beeing wider instead of longer, I can see more code. Can you try to move more options into the lines? This should give us also more space. @Dani, we are currently still experimenting.
Jonas, as an experiment you could also try to extend PopupDialog instead of Dialog and see if that saves more space.
(In reply to Lars Vogel from comment #6) > @Dani, we are currently still experimenting. OK, but what do you mean by blocking? The dialog is not modal.
Created attachment 272808 [details] Screenshot > OK, but what do you mean by blocking? The dialog is not modal. It is blocking the users view by opening a dialog. IntelliJ does it much nicer, but having the search inline in the text view (see screenshot).
(In reply to Lars Vogel from comment #7) > Jonas, as an experiment you could also try to extend PopupDialog instead of > Dialog and see if that saves more space. I tried that, but there are *a lot* of methods missing in PopupDialog that are used and overridden in the class itself. I couldn't figure out what the alternatives were. > Can you try to move more options into the lines? This should give us also more > space. What do you mean by this? More of the checkboxes like the Options section?
Matthias, WDYT? I think the new layout looks way better.
Created attachment 279756 [details] New Layout with a left alignment
The new layout looks better in my opinion as well, however, completely inlining the search would indeed be the ideal end goal.
Created attachment 279903 [details] Both layouts on Mac I'm undecided. The new look is more clearer, but consumes more valuable space. I tend slightly for the new layout.
Random thought: How about removing the close button and moving Find etc. down into the button bar? Besides the shell's close button and Esc, it seems redundant.
(In reply to Julian Honnen from comment #15) > Random thought: How about removing the close button and moving Find etc. > down into the button bar? > > Besides the shell's close button and Esc, it seems redundant. Mh. Sound's like something we should try. Why not.
(In reply to Julian Honnen from comment #15) > Random thought: How about removing the close button and moving Find etc. > down into the button bar? > > Besides the shell's close button and Esc, it seems redundant. I think it is quite common to have a Close/Finish/... button to close dialogs. I agree that normal users know the close icon and ESC. But do you know any dialog that behaves such way already? Is there some guideline for dialogs?
(In reply to Karsten Thoms from comment #17) > I think it is quite common to have a Close/Finish/... button to close > dialogs. I agree that normal users know the close icon and ESC. But do you > know any dialog that behaves such way already? > Is there some guideline for dialogs? It's irregular, sure. But I also can't think of any other non-modal, on top dialog. So we might have a case for breaking the rules ;)
Hmm I haven't tried, but it looks like this massively increases the dialog's minimum width. That would be bad for me, because I like to place the replace dialog on the right side of the editor, but still want so see as much outline as possible. Can you make it "floating", so if the make the dialog narrow, the current layout appears, but if you make it wide, your suggested layout appears? I don't like IntelliJ's solution because it wastes a lot of vertical space (which is scarcer than horizontal space with today's wide screen monitors)
(In reply to Till Brychcy from comment #19) > Can you make it "floating", so if the make the dialog narrow, the current > layout appears, but if you make it wide, your suggested layout appears? I like the idea of that responsiveness. But might not be obvious that the dialog could be enlarged, and who would do so? And "just" to have a nicer layout of buttons? At least it must be remembered then which dialog size the user set.
+1 for a dynamic layout (In reply to Karsten Thoms from comment #20) > I like the idea of that responsiveness. But might not be obvious that the > dialog could be enlarged, and who would do so? And "just" to have a nicer > layout of buttons? At least it must be remembered then which dialog size the > user set. The dialog already remembers its size and position.
What is the status here?
I will have to see how the result looks. I am against a too wide Find/Replace dialog.
This change isn't perceive as a consensual improvement, and is seen as a regression for some. That added-value is not obvious. I don't think it's worth pushing it forward. (FWIW, I also prefer a narrow dialog for find/replace so I can move it over the project explorer and see the whole editor; a wider dialog would most likely hide a part of the editor) > As a long term goal, I would like to change the Find/Relace dialog to be inline, e.g., not blocking. That's a totally different topic and not a reason to just change the dialog here. > +1 for a dynamic layout Although it's not related, that's not what this report and the attached patch are about. So I'm going to close those and let anyone willing to influence (or even code) in favor of such responsive dialog layout do it in a separate ticket.
