Bug 530628 - EPartService.ACTIVE_ON_CLOSE_TAG not always honored by PartActivationHistory
Summary: EPartService.ACTIVE_ON_CLOSE_TAG not always honored by PartActivationHistory
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 530647 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-01 14:45 EST by darrel karisch CLA
Modified: 2020-07-07 13:45 EDT (History)
2 users (show)

See Also:

Attachments
Proposed change (1.43 KB, application/octet-stream)
2018-02-01 14:47 EST, darrel karisch CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description darrel karisch CLA 2018-02-01 14:45:11 EST 
org.eclipse.e4.ui.internal.workbench.PartActivationHistory.getActivationCandidate(MPerspective) requires that a part candidate is contained in the perspective.  This is usually the case unless one drags the part, e.g. an editor, into a detached window or into stickyFolderRight.

When the application is closed with the active part outside the perspective, then that part is not restored as the active part.

This matters very little in the Eclipse IDE, but may be important for certain applications.
Comment 1 darrel karisch CLA 2018-02-01 14:47:16 EST 
Created attachment 272507 [details]
Proposed change

honor the part with EPartService.ACTIVE_ON_CLOSE_TAG regardless its location
Comment 2 Oleksandr Boochnew CLA 2018-02-02 09:12:01 EST 
*** Bug 530647 has been marked as a duplicate of this bug. ***
Comment 3 Andrey Loskutov CLA 2018-02-02 09:45:44 EST 
Darrel, can you please provide a Gerrit patch?

https://wiki.eclipse.org/Platform_UI/How_to_Contribute
Comment 4 Eclipse Genie CLA 2018-02-02 13:15:41 EST 
New Gerrit change created: https://git.eclipse.org/r/116630
Comment 5 Eclipse Genie CLA 2020-07-07 13:45:47 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.