Bug 529891 - Search entries in "Edit" menu should move to "Search"
Summary: Search entries in "Edit" menu should move to "Search"
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
Depends on:
Blocks:
 
Reported: 2018-01-16 10:18 EST by Mickael Istria CLA
Modified: 2018-01-18 03:08 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2018-01-16 10:18:51 EST
The Edit menu contains a few entries that are related to search. Since there is a dedicated Search menu, it would be more consistent to use it.
Comment 1 Andrey Loskutov CLA 2018-01-16 10:27:32 EST
This is surprising! I must confess, I don't use this "find" menu entries at all (so I'm surprising to see them there) but now looking on the menu I wonder why the "Find" was added to "Edit" and not to "Search"? Because it can replace?

@Dani: any insights?
Comment 2 Lars Vogel CLA 2018-01-16 10:29:15 EST
+1 for moving the "find" entries to the Search menu.
Comment 3 Thomas Wolf CLA 2018-01-16 11:14:21 EST
(In reply to Andrey Loskutov from comment #1)
> I wonder why the "Find" was added to "Edit" and not to "Search"? 

Perhaps because many other editors don't have a search top-level menu and typically have "Find"-related entries under "Edit"? So most users coming from other editors would first go look for a "Find" menu entry under "Edit". IntelliJ by default also has it there.
Comment 4 Mickael Istria CLA 2018-01-16 11:46:28 EST
(In reply to Thomas Wolf from comment #3)
> Perhaps because many other editors don't have a search top-level menu and
> typically have "Find"-related entries under "Edit"? So most users coming
> from other editors would first go look for a "Find" menu entry under "Edit".
> IntelliJ by default also has it there.

Ok, that could be an historical reason, by mimicking other tools. However, is it something that's still important enough for Eclipse IDE to avoid such change?
Comment 5 Lars Vogel CLA 2018-01-16 12:10:54 EST
> (In reply to Thomas Wolf from comment #3)
> > Perhaps because many other editors don't have a search top-level menu and
> > typically have "Find"-related entries under "Edit"? So most users coming
> > from other editors would first go look for a "Find" menu entry under "Edit".
> > IntelliJ by default also has it there.

That sound like a good thesis why this was done in the past.

> However,
> is it something that's still important enough for Eclipse IDE to avoid such
> change?

As we have a Search menu, it should contain all Search or Find related activities. So I'm still +1 for the change.
Comment 6 Thomas Wolf CLA 2018-01-17 14:41:27 EST
I don't care much (personally I use the keyboard shortcuts), but I'm not convinced this proposed move is a good idea. Just a few things that I would consider:

* "Find" is an editor-related command - it searches in the text of the currently active editor. "Search" contains file/workspace-related commands searching through (as subset of) the files known to Eclipse. Conceptually that's something different.

* Do we have any idea how irritating this move will/might be especially for novice users? I suspect it will run contrary to many users' expectations. Don't underestimate learned reflexes. If you go to the "Edit" menu to look for "Find" in most of your other tools, chances are that by sheer habit you'll also look there for it in Eclipse, and learning that Eclipse is an exception will take conscious effort.

* I guess you'll keep the command ID "org.eclipse.ui.edit.findReplace"? And also the name of IWorkbenchCommandConstants.EDIT_FIND_AND_REPLACE?

* If you do move the items, don't forget to update the Eclipse Help. BTW, I notice that https://help.eclipse.org/oxygen/index.jsp?nav=%2F0_4_4_5 doesn't even mention the "Search" menu. Neither does https://help.eclipse.org/oxygen/index.jsp?nav=%2F0_4_4_4 .
Comment 7 Lars Vogel CLA 2018-01-17 18:45:48 EST
(In reply to Thomas Wolf from comment #6)
> I don't care much (personally I use the keyboard shortcuts), but I'm not
> convinced this proposed move is a good idea. 

Thomas argumentation convinced me, I'm now -1 for this change. I suggest to mark this as wontfix.
Comment 8 Mickael Istria CLA 2018-01-18 03:08:34 EST
As the value is relatively low, and there is no consensus; let's stick with status quo. If anyone has stronger arguments to oppose to Thomas' ones, feel free to reopen this issue.