Bug 529742 - Missing top line border in views (CTabFolder)
Summary: Missing top line border in views (CTabFolder)
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.7.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.17 M1   Edit
Assignee: Paul Pazderski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-12 10:33 EST by Kristoffer Sokolowski CLA
Modified: 2020-07-08 11:43 EDT (History)
2 users (show)

See Also:

Attachments
Missing top border (53.77 KB, image/png)
2018-01-12 10:33 EST, Kristoffer Sokolowski CLA 		no flags Details
CTabPanel body boarder before and after change (25.26 KB, image/png)
2020-05-30 08:18 EDT, Paul Pazderski CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristoffer Sokolowski CLA 2018-01-12 10:33:02 EST 
Created attachment 272248 [details]
Missing top border

When using Theme "Window Classic"-theme the top border is missing on CTabFolder in views (and editors) when no editor is open (see attached image) and view is out of focus, or you're resizing a view with an editor open. 

This works fine in v.3.6.2.

I suspect that this is related to CTabFolderRender.
Comment 1 Eclipse Genie CLA 2020-04-08 10:00:03 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Eclipse Genie CLA 2020-05-30 08:16:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/163885
Comment 3 Paul Pazderski CLA 2020-05-30 08:18:12 EDT 
Created attachment 283104 [details]
CTabPanel body boarder before and after change

(In reply to Kristoffer Sokolowski from comment #0)
> I suspect that this is related to CTabFolderRender.

It is, and this bug bothered me since years. Focusing the shared area without editors or views is one way to reproduce. The other is that the view/editor is active but the containing shell has no focus. E.g. selecting another application, opening a dialog in Eclipse. On Windows even opening a drop-down toolbar item works.

The attached screenshot shows the difference for CTabFolder before and after patch.

The issue is in different parts of CTabFolderRenderer use different color for the state selected + not-highlighted.

Note that my change will not restore the missing top boarder but will remove* the incomplete boarder. I don't know how it was in 3.6.2 but the current CTabFolder lacks proper support to differ selected and selected but non-focus. See bug 514164 and bug 507611 for that.

Overall I think my change improves the situation.


* in fact it is drawn in a different color as you can see in the screenshot.
Comment 4 Paul Pazderski CLA 2020-05-30 08:18:47 EDT 
.
Comment 6 Alexander Kurtakov CLA 2020-06-10 07:44:20 EDT 
Thanks Paul
Comment 7 Paul Pazderski CLA 2020-07-08 11:43:40 EDT 
Verified in Eclipse SDK

Version: 2020-09 (4.17)
Build id: I20200708-0600